Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

test_user_groups: Remove incorrect comment. 

The comment about non-admins and non-moderators who are not
member of the group cannot update subgroups of that group
is not correct since there is no such restriction now after
c9d527603. The test passes because the member user is not
part of can_manage_group or can_manage_all_groups.
This commit is contained in:
Sahil Batra 2024-10-17 15:59:51 +05:30 committed by Tim Abbott
parent b748623a77
commit 30e0c72919
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
zerver/tests/test_user_groups.py
View File

@ -2762,7 +2762,6 @@ class UserGroupAPITestCase(UserGroupTestCase):
test_group = check_add_user_group(realm, "test", [hamlet], acting_user=hamlet)
self.login("cordelia")
# Non-admin and non-moderators who are not a member of group cannot add or remove subgroups.
params = {"add": orjson.dumps([leadership_group.id]).decode()}
result = self.client_post(f"/json/user_groups/{support_group.id}/subgroups", info=params)
self.assert_json_error(result, "Insufficient permission")