Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

stream_popover: Remove useless old_topic_name check. 

This has been present since this modal was first introduced in
b9098a42d4, but as far as I can tell, it
has never been correct. We know `old_topic_name` is not
null/undefined, since we do a check with it trimmed earlier in the
function, and there is no product reason why we would would to
silently fail to move a topic because its name was the empty string.
This commit is contained in:
Tim Abbott 2023-02-03 16:52:39 -08:00
parent 9997131df3
commit 3099487bc3
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
static/js/stream_popover.js
View File

@ -504,16 +504,14 @@ export function build_move_topic_to_stream_popover(current_stream_id, topic_name
current_stream_id, current_stream_id,
old_topic_name, old_topic_name,
(message_id) => { (message_id) => {
if (old_topic_name) { message_edit.move_topic_containing_message_to_stream(
message_edit.move_topic_containing_message_to_stream( message_id,
message_id, select_stream_id,
select_stream_id, new_topic_name,
new_topic_name, send_notification_to_new_thread,
send_notification_to_new_thread, send_notification_to_old_thread,
send_notification_to_old_thread, propagate_mode,
propagate_mode, );
);
}
}, },
(xhr) => { (xhr) => {
dialog_widget.hide_dialog_spinner(); dialog_widget.hide_dialog_spinner();