Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

message: Hide first action button on narrow widths. 

Fixes zulip#19759

Before grid, there was overlap of action buttons and text (photo 1).
With grid, there was just very little space for messages (photo 2).
With this commit, the message gets a bit more space (photo 3).

This helps us add more width to the content column of message
on narrow widths. Note that it will still always be less than
before grid, since we are explicitly preventing overlap.
This commit is contained in:
Aman Agrawal 2022-12-09 09:13:25 +00:00 committed by Tim Abbott
parent 26011c98fd
commit 2fa88362bc
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
static/js/popover_menus_data.js
View File

@ -87,6 +87,17 @@ export function get_actions_popover_content_context(message_id) {
const should_display_read_receipts_option =
page_params.realm_enable_read_receipts && not_spectator;
function is_add_reaction_icon_visible() {
const $message_row = message_lists.current.get_row(message_id);
return $message_row.find(".message_controls.reaction_button").is(":visible");
}
// Since we only display msg actions and star icons on windows smaller than
// `media_breakpoints.sm_min`, we need to include the reaction button in the
// popover if it is not displayed.
const should_display_add_reaction_option =
!message.is_me_message && !is_add_reaction_icon_visible();
return {
message_id: message.id,
stream_id: message.stream_id,
@ -96,7 +107,7 @@ export function get_actions_popover_content_context(message_id) {
view_source_menu_item,
should_display_collapse,
should_display_uncollapse,
should_display_add_reaction_option: message.sent_by_me,
should_display_add_reaction_option,
should_display_edit_history_option,
should_display_hide_option,
conversation_time_uri,