Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

modal: Fix flex-direction property for modal__content. 

The flex-direction property for modal__content should
be set to column as we want to display the elements.

This does not affect most of the modals since they
do not have multiple direct child elements that are
visible at same time and the data-simplebar attribute
already sets the "flex-direction: column" property to
the elements where it is used.

But in the email address visibility modal on user
registration page, there are multiple direct child
elements for the "modal__content" element and we need
to set "flex-direction: column" property for them to
work correctly. We also change the width of select
element in the modal to "fit-content" to avoid it
taking the whole width even when not required.

This commit also fixes the bug in login_to_access
modal, since the `modal__content` for it also
has two direct child elements.
This commit is contained in:
Sahil Batra 2023-03-31 09:10:47 +05:30 committed by Tim Abbott
parent 790e4854dd
commit 2ebb9834cd
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
web/styles/modal.css
View File

@ -81,6 +81,7 @@
.modal__content {
display: flex;
flex-direction: column;
font-size: 1rem;
overflow-y: auto;
padding: 0 24px;

2
web/styles/portico/portico_signin.css
View File

@ -666,7 +666,7 @@ html {
& select {
margin-bottom: 10px;
width: auto;
width: fit-content;
font-size: 16px;
font-family: inherit;
}