Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

popovers: Fix initial focus on popover simplebar container. 

This commit is a follow-up of 43eebbf9c6,
and it sets `data-simplebar-tab-index="-1"` on the remaining popovers.

This prevents the simplebar container from taking focus while trying to
navigate the popovers via the keyboard, thus fixing the bug where the
user had to click the down key twice before reaching the first
focus-able popover menu option.
This commit is contained in:
Sayam Samal 2024-10-09 13:43:37 +05:30 committed by Tim Abbott
parent a1d616f8c0
commit 2e0cd48141
7 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
web/templates/popovers/left_sidebar/left_sidebar_all_messages_popover.hbs
View File

@ -1,4 +1,4 @@
<div class="popover-menu" data-simplebar>
<div class="popover-menu" data-simplebar data-simplebar-tab-index="-1">
<ul role="menu" class="popover-menu-list">
{{#if is_home_view}}
<li role="none" class="link-item popover-menu-list-item">

2
web/templates/popovers/left_sidebar/left_sidebar_condensed_views_popover.hbs
View File

@ -1,4 +1,4 @@
<div class="popover-menu" data-simplebar>
<div class="popover-menu" data-simplebar data-simplebar-tab-index="-1">
<ul role="menu" class="popover-menu-list condensed-views-popover-menu">
<li role="none" class="link-item popover-menu-list-item condensed-views-popover-menu-reactions">
<a href="#narrow/has/reaction/sender/me" role="menuitem" class="popover-menu-link tippy-left-sidebar-tooltip" data-tooltip-template-id="my-reactions-tooltip-template" tabindex="0">

2
web/templates/popovers/left_sidebar/left_sidebar_drafts_popover.hbs
View File

@ -1,4 +1,4 @@
<div class="popover-menu" data-simplebar>
<div class="popover-menu" data-simplebar data-simplebar-tab-index="-1">
<ul role="menu" class="popover-menu-list">
<li role="none" class="link-item popover-menu-list-item">
<a role="menuitem" id="delete_all_drafts_sidebar" class="popover-menu-link" tabindex="0">

2
web/templates/popovers/left_sidebar/left_sidebar_inbox_popover.hbs
View File

@ -1,4 +1,4 @@
<div class="popover-menu" data-simplebar>
<div class="popover-menu" data-simplebar data-simplebar-tab-index="-1">
<ul role="menu" class="popover-menu-list">
{{#if is_home_view}}
<li role="none" class="link-item popover-menu-list-item">

2
web/templates/popovers/left_sidebar/left_sidebar_recent_view_popover.hbs
View File

@ -1,4 +1,4 @@
<div class="popover-menu" data-simplebar>
<div class="popover-menu" data-simplebar data-simplebar-tab-index="-1">
<ul role="menu" class="popover-menu-list">
{{#if is_home_view}}
<li role="none" class="link-item popover-menu-list-item">

2
web/templates/popovers/left_sidebar/left_sidebar_starred_messages_popover.hbs
View File

@ -1,4 +1,4 @@
<div class="popover-menu" data-simplebar>
<div class="popover-menu" data-simplebar data-simplebar-tab-index="-1">
<ul role="menu" class="popover-menu-list">
{{#if show_unstar_all_button}}
<li role="none" class="link-item popover-menu-list-item">

2
web/templates/popovers/left_sidebar/left_sidebar_stream_setting_popover.hbs
View File

@ -1,4 +1,4 @@
<div class="popover-menu" data-simplebar>
<div class="popover-menu" data-simplebar data-simplebar-tab-index="-1">
<ul role="menu" class="popover-menu-list">
<li role="none" class="link-item popover-menu-list-item">
<a href="#channels/notsubscribed" role="menuitem" class="popover-menu-link navigate_and_close_popover" tabindex="0">