From 2c9d4eaeee695f1c3c476544ed1cad8ce201dd7e Mon Sep 17 00:00:00 2001 From: evykassirer Date: Sat, 12 Oct 2024 23:24:20 -0700 Subject: [PATCH] narrow_banner: Update invalid/private channel empty narrow copy. Decided here: https://chat.zulip.org/#narrow/channel/6-frontend/topic/unknown.20channel.20ID.20-.20empty.20feed.20banner/near/1956965 --- web/src/narrow_banner.ts | 5 ++++- web/tests/message_view.test.js | 8 ++++++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/web/src/narrow_banner.ts b/web/src/narrow_banner.ts index 528b2015ba..52dc26551a 100644 --- a/web/src/narrow_banner.ts +++ b/web/src/narrow_banner.ts @@ -290,7 +290,10 @@ export function pick_empty_narrow_banner(): NarrowBannerData { } return { - title: $t({defaultMessage: "This channel does not exist or is private."}), + title: $t({ + defaultMessage: + "This channel doesn't exist, or you are not allowed to view it.", + }), }; } // else fallthrough to default case diff --git a/web/tests/message_view.test.js b/web/tests/message_view.test.js index d353e50256..767cac8c7b 100644 --- a/web/tests/message_view.test.js +++ b/web/tests/message_view.test.js @@ -253,7 +253,9 @@ run_test("show_empty_narrow_message", ({mock_template, override}) => { narrow_banner.show_empty_narrow_message(); assert.equal( $(".empty_feed_notice_main").html(), - empty_narrow_html("translated: This channel does not exist or is private."), + empty_narrow_html( + "translated: This channel doesn't exist, or you are not allowed to view it.", + ), ); // for non-subbed public stream @@ -573,7 +575,9 @@ run_test("show_empty_narrow_message", ({mock_template, override}) => { narrow_banner.show_empty_narrow_message(); assert.equal( $(".empty_feed_notice_main").html(), - empty_narrow_html("translated: This channel does not exist or is private."), + empty_narrow_html( + "translated: This channel doesn't exist, or you are not allowed to view it.", + ), ); set_filter([