Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

users: Send event on commit in do_update_outgoing_webhook_service. 

Earlier, we were using 'send_event' in
'do_update_outgoing_webhook_service' which can lead to a
situation, if any db operation is added after the 'send_event'
in future, where we enqueue events but the action function fails
at a later stage.

Events should not be sent until we know we're not rolling back.

Fixes part of #30489.
This commit is contained in:
Prakhar Pratyush 2024-08-23 11:26:36 +05:30 committed by Tim Abbott
parent 30edd1a3b0
commit 2b6c5260a5
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
zerver/actions/users.py
View File

@ -536,6 +536,7 @@ def do_change_can_create_users(user_profile: UserProfile, value: bool) -> None:
user_profile.save(update_fields=["can_create_users"])
@transaction.atomic(durable=True)
def do_update_outgoing_webhook_service(
bot_profile: UserProfile, service_interface: int, service_payload_url: str
) -> None:
@ -545,7 +546,7 @@ def do_update_outgoing_webhook_service(
service.base_url = service_payload_url
service.interface = service_interface
service.save()
send_event(
send_event_on_commit(
bot_profile.realm,
dict(
type="realm_bot",