From 2b572628d0c9baaf65f928992fef7fc7ea614599 Mon Sep 17 00:00:00 2001
From: Shubham Padia <shubham@zulip.com>
Date: Tue, 9 Jul 2024 12:26:44 +0000
Subject: [PATCH] user_group_popover: Don't show group settings link for system
 groups.

System groups are immutable and that's why we should remove the group
settings link from the group popover for system groups.
---
 web/src/user_group_popover.ts                      | 1 +
 web/templates/popovers/user_group_info_popover.hbs | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/web/src/user_group_popover.ts b/web/src/user_group_popover.ts
index 36bd05e6fb..7006480ca4 100644
--- a/web/src/user_group_popover.ts
+++ b/web/src/user_group_popover.ts
@@ -100,6 +100,7 @@ export function toggle_user_group_info_popover(
                     ),
                     group_edit_url: hash_util.group_edit_url(group, "general"),
                     is_guest: current_user.is_guest,
+                    is_system_group: group.is_system_group,
                 };
                 instance.setContent(ui_util.parse_html(render_user_group_info_popover(args)));
             },
diff --git a/web/templates/popovers/user_group_info_popover.hbs b/web/templates/popovers/user_group_info_popover.hbs
index 35797eea80..75821e3666 100644
--- a/web/templates/popovers/user_group_info_popover.hbs
+++ b/web/templates/popovers/user_group_info_popover.hbs
@@ -24,7 +24,7 @@
                 {{/each}}
             </ul>
         </li>
-        {{#unless is_guest}}
+        {{#unless (or is_guest is_system_group)}}
             <li role="separator" class="popover-menu-separator hidden-for-spectators"></li>
             <li role="none" class="link-item popover-menu-list-item hidden-for-spectators">
                 <a href="{{group_edit_url}}" role="menuitem" class="navigate-link-on-enter popover-menu-link" tabindex="0">