Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

test_push_notifications: Fix incorrect "read" flag test. 

It was unclear what the original test was testing, and more
importantly, the test passed even if one removed the `read` flag
check in the `handle_push_notifications` function, so we fix it
to be more comprehensive.
This commit is contained in:
Abhijeet Prasad Bodas 2021-06-10 18:08:54 +05:30 committed by Tim Abbott
parent c6a31dcd9f
commit 2b438fd7ce
1 changed files with 24 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
zerver/tests/test_push_notifications.py
View File

@ -917,9 +917,9 @@ class HandlePushNotificationTest(PushNotificationTest):
def test_read_message(self, mock_push_notifications: mock.MagicMock) -> None: def test_read_message(self, mock_push_notifications: mock.MagicMock) -> None:
user_profile = self.example_user("hamlet") user_profile = self.example_user("hamlet")
message = self.get_message(Recipient.PERSONAL, type_id=1) message = self.get_message(Recipient.PERSONAL, type_id=1)
UserMessage.objects.create(
usermessage = UserMessage.objects.create(
user_profile=user_profile, user_profile=user_profile,
flags=UserMessage.flags.read,
message=message, message=message,
) )
@ -927,8 +927,28 @@ class HandlePushNotificationTest(PushNotificationTest):
"message_id": message.id, "message_id": message.id,
"trigger": "private_message", "trigger": "private_message",
} }
handle_push_notification(user_profile.id, missed_message)
mock_push_notifications.assert_called_once() # If the message is unread, we should send push notifications.
with mock.patch(
"zerver.lib.push_notifications.send_apple_push_notification"
) as mock_send_apple, mock.patch(
"zerver.lib.push_notifications.send_android_push_notification"
) as mock_send_android:
handle_push_notification(user_profile.id, missed_message)
mock_send_apple.assert_called_once()
mock_send_android.assert_called_once()
# If the message has been read, don't send push notifications.
usermessage.flags.read = True
usermessage.save()
with mock.patch(
"zerver.lib.push_notifications.send_apple_push_notification"
) as mock_send_apple, mock.patch(
"zerver.lib.push_notifications.send_android_push_notification"
) as mock_send_android:
handle_push_notification(user_profile.id, missed_message)
mock_send_apple.assert_not_called()
mock_send_android.assert_not_called()
def test_deleted_message(self) -> None: def test_deleted_message(self) -> None:
"""Simulates the race where message is deleted before handlingx push notifications""" """Simulates the race where message is deleted before handlingx push notifications"""