mirror of https://github.com/zulip/zulip.git
composebox_typeahead: Allow for undefined topic in PersonSuggestionOpts.
Fixes this error, which occured when editing DM messages and bringing up the mention typeahead with "@" https://zulip.sentry.io/issues/5389123227/events/46ab6c6ca68344ac89af7444fa0f8c39/?project=4504556882821120
This commit is contained in:
parent
5f3d6ac983
commit
27b5c61399
|
@ -568,7 +568,7 @@ export function filter_and_sort_mentions(
|
||||||
query: string,
|
query: string,
|
||||||
opts: {
|
opts: {
|
||||||
stream_id: number | undefined;
|
stream_id: number | undefined;
|
||||||
topic: string;
|
topic: string | undefined;
|
||||||
},
|
},
|
||||||
): (UserGroupPillData | UserOrMentionPillData)[] {
|
): (UserGroupPillData | UserOrMentionPillData)[] {
|
||||||
return get_person_suggestions(query, {
|
return get_person_suggestions(query, {
|
||||||
|
@ -613,7 +613,7 @@ type PersonSuggestionOpts = {
|
||||||
want_broadcast: boolean;
|
want_broadcast: boolean;
|
||||||
filter_pills: boolean;
|
filter_pills: boolean;
|
||||||
stream_id: number | undefined;
|
stream_id: number | undefined;
|
||||||
topic: string;
|
topic: string | undefined;
|
||||||
filter_groups_for_guests?: boolean;
|
filter_groups_for_guests?: boolean;
|
||||||
filter_groups_for_mention?: boolean;
|
filter_groups_for_mention?: boolean;
|
||||||
};
|
};
|
||||||
|
@ -723,7 +723,7 @@ export function get_person_suggestions(
|
||||||
|
|
||||||
function get_stream_topic_data(input_element: TypeaheadInputElement): {
|
function get_stream_topic_data(input_element: TypeaheadInputElement): {
|
||||||
stream_id: number | undefined;
|
stream_id: number | undefined;
|
||||||
topic: string;
|
topic: string | undefined;
|
||||||
} {
|
} {
|
||||||
let stream_id;
|
let stream_id;
|
||||||
let topic;
|
let topic;
|
||||||
|
@ -740,7 +740,6 @@ function get_stream_topic_data(input_element: TypeaheadInputElement): {
|
||||||
stream_id = compose_state.stream_id();
|
stream_id = compose_state.stream_id();
|
||||||
topic = compose_state.topic();
|
topic = compose_state.topic();
|
||||||
}
|
}
|
||||||
assert(topic !== undefined);
|
|
||||||
return {
|
return {
|
||||||
stream_id,
|
stream_id,
|
||||||
topic,
|
topic,
|
||||||
|
|
Loading…
Reference in New Issue