From 276648ef872dbbe7d59b624dc57e0e165fdd75a4 Mon Sep 17 00:00:00 2001 From: Prakhar Pratyush Date: Thu, 3 Oct 2024 19:09:36 +0530 Subject: [PATCH] realm_settings: Remove 'enable_spectator_access' from update_fields. In 'do_change_realm_plan_type' function we use 'do_set_realm_property' to set 'enable_spectator_access' to False. There is no need to again update that field. This change was included in d2f2fbf6b90a5f28c8e19ed156ee78fc82f08df8. --- zerver/actions/realm_settings.py | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/zerver/actions/realm_settings.py b/zerver/actions/realm_settings.py index 12d80b72fc..8541ec1463 100644 --- a/zerver/actions/realm_settings.py +++ b/zerver/actions/realm_settings.py @@ -784,13 +784,7 @@ def do_change_realm_plan_type( update_first_visible_message_id(realm) - realm.save( - update_fields=[ - "_max_invites", - "enable_spectator_access", - "message_visibility_limit", - ] - ) + realm.save(update_fields=["_max_invites", "message_visibility_limit"]) event = { "type": "realm",