From 262689da7645e654c2efbed1a001aed50b54f46b Mon Sep 17 00:00:00 2001 From: Alex Vandiver Date: Fri, 12 Jul 2024 03:42:22 +0000 Subject: [PATCH] thumbnail: Fix MAX_EMOJI_GIF_FILE_SIZE_BYTES check to be post-resize. This check was intended to check the post-resized image size, not the pre-resized image. --- zerver/lib/upload/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zerver/lib/upload/__init__.py b/zerver/lib/upload/__init__.py index 186424474b..90d185019e 100644 --- a/zerver/lib/upload/__init__.py +++ b/zerver/lib/upload/__init__.py @@ -361,7 +361,7 @@ def upload_emoji_image( if still_image_data is not None: if len(still_image_data) > MAX_EMOJI_GIF_FILE_SIZE_BYTES: # nocoverage raise BadImageError(_("Image size exceeds limit")) - elif len(image_data) > MAX_EMOJI_GIF_FILE_SIZE_BYTES: # nocoverage + elif len(resized_image_data) > MAX_EMOJI_GIF_FILE_SIZE_BYTES: # nocoverage raise BadImageError(_("Image size exceeds limit")) backend.upload_single_emoji_image(emoji_path, content_type, user_profile, resized_image_data) if still_image_data is None: