Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

org settings: Fix dropdown value inconsistency. 

The value in the handlebars template for `invite_to_stream_policy`
is inconsistent with the value in the js file. Changing all three
occurances to a third value, since that's the one we'll want moving
forward.

Co-Authored-By: Rishi Gupta <rishig@zulipchat.com>
This commit is contained in:
David Wood 2019-05-14 14:18:51 -07:00 committed by Tim Abbott
parent 68d3b9f5ca
commit 24cb31329c
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
static/js/settings_org.js
View File

@ -98,7 +98,7 @@ function get_property_value(property_name) {
return "by_admins_only";
}
if (page_params.realm_invite_to_stream_policy === 3) {
return "by_members_with_waiting_period";
return "by_full_members";
}
}
@ -766,7 +766,7 @@ exports.build_page = function () {
data.invite_to_stream_policy = 2;
} else if (invite_to_stream_policy === "by_members") {
data.invite_to_stream_policy = 1;
} else if (invite_to_stream_policy === "by_members_with_waiting_period") {
} else if (invite_to_stream_policy === "by_full_members") {
data.invite_to_stream_policy = 3;
}
} else if (subsection === 'org_join') {

2
static/templates/settings/organization-permissions-admin.handlebars
View File

@ -87,7 +87,7 @@
<select name="realm_invite_to_stream_policy" id="id_realm_invite_to_stream_policy" class="prop-element">
<option value="by_members">{{t "Members and admins" }}</option>
<option value="by_admins_only">{{t "Admins only" }}</option>
<option value="by_members">{{t "All admins and members who can create streams" }}</option>
<option value="by_full_members">{{t "All admins and members who can create streams" }}</option>
</select>
</div>