Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

user_setting: Update wording for "Mark messages as read on scroll" setting. 

Previously, the user setting "Mark messages as read on scroll" sounded
quite awkward and possibly confusing at times. We should update the text
to something more clear and concise. This change will change "Mark messages
as read on scroll" to "Automatically mark messages as read".

The help center article is also fixed to name which setting is being
adjusted.
This commit is contained in:
Joelute 2023-05-08 14:18:36 -04:00 committed by Tim Abbott
parent 9e5c1eff4b
commit 245c855376
3 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
help/marking-messages-as-read.md
View File

@ -21,7 +21,9 @@ are at your computer. You will still be able to
{settings_tab|display-settings}
1. Under **Advanced**, select **Always**, **Never** or **Only in conversation views**.
1. Under **Advanced**, click on the **Automatically mark messages as
read** dropdown, and select **Always**, **Never** or **Only in
conversation views**.
{tab|mobile}

4
web/src/message_list.js
View File

@ -190,7 +190,7 @@ export class MessageList {
properties of the message_list_data object.
* The user recently marked messages in the view as unread, and
we don't want to lose that state.
* The user has "Mark messages as read on scroll" option
* The user has "Automatically mark messages as read" option
turned on in their user settings.
*/
const filter = this.data.filter;
@ -214,7 +214,7 @@ export class MessageList {
/*
Similar to can_mark_messages_read() above, this is a helper
function to check if messages can be automatically read without
the "Do not mark messages as read on scroll" setting.
the "Automatically mark messages as read" setting.
*/
return this.data.can_mark_messages_read() && !this.reading_prevented;
}

2
web/templates/settings/display_settings.hbs
View File

@ -81,7 +81,7 @@
</div>
<div class="input-group">
<label for="web_mark_read_on_scroll_policy" class="dropdown-title">{{t "Mark messages as read on scroll" }}
<label for="web_mark_read_on_scroll_policy" class="dropdown-title">{{t "Automatically mark messages as read" }}
{{> ../help_link_widget link="/help/marking-messages-as-read" }}
</label>
<select name="web_mark_read_on_scroll_policy" class="setting_web_mark_read_on_scroll_policy prop-element settings_select bootstrap-focus-style" id="{{prefix}}web_mark_read_on_scroll_policy" data-setting-widget-type="number">