From 23d98c256588986cbfd9ffe081dbd26aa308d89b Mon Sep 17 00:00:00 2001
From: Anders Kaseorg <anders@zulipchat.com>
Date: Mon, 17 Feb 2020 15:08:43 -0800
Subject: [PATCH] eslintrc: Move global exemptions to an override.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

We don’t want our globals leaking into @zulip/shared.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
---
 .eslintrc.json | 416 +++++++++++++++++++++++++------------------------
 1 file changed, 211 insertions(+), 205 deletions(-)

diff --git a/.eslintrc.json b/.eslintrc.json
index e89eee690c..ba308bd0f7 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -8,211 +8,6 @@
         "warnOnUnsupportedTypeScriptVersion": false,
         "sourceType": "module"
     },
-    "globals": {
-        "$": false,
-        "ClipboardJS": false,
-        "Dict": false,
-        "FetchStatus": false,
-        "Filter": false,
-        "Handlebars": false,
-        "LightboxCanvas": false,
-        "MessageListData": false,
-        "MessageListView": false,
-        "Plotly": false,
-        "Sortable": false,
-        "WinChan": false,
-        "XDate": false,
-        "_": false,
-        "activity": false,
-        "admin": false,
-        "alert_words": false,
-        "alert_words_ui": false,
-        "attachments_ui": false,
-        "avatar": false,
-        "billing": false,
-        "blueslip": false,
-        "bot_data": false,
-        "bridge": false,
-        "buddy_data": false,
-        "buddy_list": false,
-        "channel": false,
-        "click_handlers": false,
-        "color_data": false,
-        "colorspace": false,
-        "common": false,
-        "components": false,
-        "compose": false,
-        "compose_actions": false,
-        "compose_fade": false,
-        "compose_pm_pill": false,
-        "compose_state": false,
-        "compose_ui": false,
-        "composebox_typeahead": false,
-        "condense": false,
-        "confirm_dialog": false,
-        "copy_and_paste": false,
-        "csrf_token": false,
-        "current_msg_list": true,
-        "drafts": false,
-        "echo": false,
-        "emoji": false,
-        "emoji_picker": false,
-        "favicon": false,
-        "feature_flags": false,
-        "feedback_widget": false,
-        "fenced_code": false,
-        "flatpickr": false,
-        "floating_recipient_bar": false,
-        "gear_menu": false,
-        "hash_util": false,
-        "hashchange": false,
-        "helpers": false,
-        "history": false,
-        "home_msg_list": false,
-        "hotspots": false,
-        "i18n": false,
-        "info_overlay": false,
-        "input_pill": false,
-        "invite": false,
-        "jQuery": false,
-        "katex": false,
-        "keydown_util": false,
-        "lightbox": false,
-        "list_cursor": false,
-        "list_render": false,
-        "list_util": false,
-        "loading": false,
-        "localStorage": false,
-        "local_message": false,
-        "localstorage": false,
-        "location": false,
-        "markdown": false,
-        "marked": false,
-        "md5": false,
-        "message_edit": false,
-        "message_events": false,
-        "message_fetch": false,
-        "message_flags": false,
-        "message_list": false,
-        "message_live_update": false,
-        "message_scroll": false,
-        "message_store": false,
-        "message_util": false,
-        "message_viewport": false,
-        "moment": false,
-        "muting": false,
-        "muting_ui": false,
-        "narrow": false,
-        "narrow_state": false,
-        "navigate": false,
-        "night_mode": false,
-        "notifications": false,
-        "overlays": false,
-        "padded_widget": false,
-        "page_params": false,
-        "panels": false,
-        "people": false,
-        "pm_conversations": false,
-        "pm_list": false,
-        "pm_list_dom": false,
-        "pointer": false,
-        "popovers": false,
-        "presence": false,
-        "reactions": false,
-        "realm_icon": false,
-        "realm_logo": false,
-        "realm_night_logo": false,
-        "recent_senders": false,
-        "reload": false,
-        "reload_state": false,
-        "reminder": false,
-        "resize": false,
-        "rows": false,
-        "rtl": false,
-        "run_test": false,
-        "schema": false,
-        "scroll_bar": false,
-        "scroll_util": false,
-        "search": false,
-        "search_pill": false,
-        "search_pill_widget": false,
-        "search_suggestion": false,
-        "search_util": false,
-        "sent_messages": false,
-        "server_events": false,
-        "server_events_dispatch": false,
-        "settings": false,
-        "settings_account": false,
-        "settings_bots": false,
-        "settings_display": false,
-        "settings_emoji": false,
-        "settings_exports": false,
-        "settings_linkifiers": false,
-        "settings_invites": false,
-        "settings_muting": false,
-        "settings_notifications": false,
-        "settings_org": false,
-        "settings_panel_menu": false,
-        "settings_profile_fields": false,
-        "settings_sections": false,
-        "settings_streams": false,
-        "settings_toggle": false,
-        "settings_ui": false,
-        "settings_user_groups": false,
-        "settings_users": false,
-        "starred_messages": false,
-        "stream_color": false,
-        "stream_create": false,
-        "stream_data": false,
-        "stream_edit": false,
-        "stream_events": false,
-        "stream_list": false,
-        "stream_muting": false,
-        "stream_popover": false,
-        "stream_sort": false,
-        "stream_ui_updates": false,
-        "StripeCheckout": false,
-        "submessage": false,
-        "subs": false,
-        "tab_bar": false,
-        "templates": false,
-        "tictactoe_widget": false,
-        "timerender": false,
-        "todo_widget": false,
-        "top_left_corner": false,
-        "topic_data": false,
-        "topic_generator": false,
-        "topic_list": false,
-        "topic_zoom": false,
-        "transmit": false,
-        "tutorial": false,
-        "typeahead_helper": false,
-        "typing": false,
-        "typing_data": false,
-        "typing_events": false,
-        "ui": false,
-        "ui_init": false,
-        "ui_report": false,
-        "ui_util": false,
-        "unread": false,
-        "unread_ops": false,
-        "unread_ui": false,
-        "upgrade": false,
-        "upload": false,
-        "upload_widget": false,
-        "user_events": false,
-        "user_groups": false,
-        "user_pill": false,
-        "user_search": false,
-        "user_status": false,
-        "user_status_ui": false,
-        "poll_widget": false,
-        "vdom": false,
-        "widgetize": false,
-        "zcommand": false,
-        "zform": false,
-        "zxcvbn": false
-    },
     "plugins": [
         "eslint-plugin-empty-returns"
     ],
@@ -410,6 +205,217 @@
         "yoda": "error"
     },
     "overrides": [
+        {
+            "files": [
+                "frontend_tests/**/*.{js,ts}",
+                "static/js/**/*.{js,ts}"
+            ],
+            "globals": {
+                "$": false,
+                "ClipboardJS": false,
+                "Dict": false,
+                "FetchStatus": false,
+                "Filter": false,
+                "Handlebars": false,
+                "LightboxCanvas": false,
+                "MessageListData": false,
+                "MessageListView": false,
+                "Plotly": false,
+                "Sortable": false,
+                "WinChan": false,
+                "XDate": false,
+                "_": false,
+                "activity": false,
+                "admin": false,
+                "alert_words": false,
+                "alert_words_ui": false,
+                "attachments_ui": false,
+                "avatar": false,
+                "billing": false,
+                "blueslip": false,
+                "bot_data": false,
+                "bridge": false,
+                "buddy_data": false,
+                "buddy_list": false,
+                "channel": false,
+                "click_handlers": false,
+                "color_data": false,
+                "colorspace": false,
+                "common": false,
+                "components": false,
+                "compose": false,
+                "compose_actions": false,
+                "compose_fade": false,
+                "compose_pm_pill": false,
+                "compose_state": false,
+                "compose_ui": false,
+                "composebox_typeahead": false,
+                "condense": false,
+                "confirm_dialog": false,
+                "copy_and_paste": false,
+                "csrf_token": false,
+                "current_msg_list": true,
+                "drafts": false,
+                "echo": false,
+                "emoji": false,
+                "emoji_picker": false,
+                "favicon": false,
+                "feature_flags": false,
+                "feedback_widget": false,
+                "fenced_code": false,
+                "flatpickr": false,
+                "floating_recipient_bar": false,
+                "gear_menu": false,
+                "hash_util": false,
+                "hashchange": false,
+                "helpers": false,
+                "history": false,
+                "home_msg_list": false,
+                "hotspots": false,
+                "i18n": false,
+                "info_overlay": false,
+                "input_pill": false,
+                "invite": false,
+                "jQuery": false,
+                "katex": false,
+                "keydown_util": false,
+                "lightbox": false,
+                "list_cursor": false,
+                "list_render": false,
+                "list_util": false,
+                "loading": false,
+                "localStorage": false,
+                "local_message": false,
+                "localstorage": false,
+                "location": false,
+                "markdown": false,
+                "marked": false,
+                "md5": false,
+                "message_edit": false,
+                "message_events": false,
+                "message_fetch": false,
+                "message_flags": false,
+                "message_list": false,
+                "message_live_update": false,
+                "message_scroll": false,
+                "message_store": false,
+                "message_util": false,
+                "message_viewport": false,
+                "moment": false,
+                "muting": false,
+                "muting_ui": false,
+                "narrow": false,
+                "narrow_state": false,
+                "navigate": false,
+                "night_mode": false,
+                "notifications": false,
+                "overlays": false,
+                "padded_widget": false,
+                "page_params": false,
+                "panels": false,
+                "people": false,
+                "pm_conversations": false,
+                "pm_list": false,
+                "pm_list_dom": false,
+                "pointer": false,
+                "popovers": false,
+                "presence": false,
+                "reactions": false,
+                "realm_icon": false,
+                "realm_logo": false,
+                "realm_night_logo": false,
+                "recent_senders": false,
+                "reload": false,
+                "reload_state": false,
+                "reminder": false,
+                "resize": false,
+                "rows": false,
+                "rtl": false,
+                "run_test": false,
+                "schema": false,
+                "scroll_bar": false,
+                "scroll_util": false,
+                "search": false,
+                "search_pill": false,
+                "search_pill_widget": false,
+                "search_suggestion": false,
+                "search_util": false,
+                "sent_messages": false,
+                "server_events": false,
+                "server_events_dispatch": false,
+                "settings": false,
+                "settings_account": false,
+                "settings_bots": false,
+                "settings_display": false,
+                "settings_emoji": false,
+                "settings_exports": false,
+                "settings_linkifiers": false,
+                "settings_invites": false,
+                "settings_muting": false,
+                "settings_notifications": false,
+                "settings_org": false,
+                "settings_panel_menu": false,
+                "settings_profile_fields": false,
+                "settings_sections": false,
+                "settings_streams": false,
+                "settings_toggle": false,
+                "settings_ui": false,
+                "settings_user_groups": false,
+                "settings_users": false,
+                "starred_messages": false,
+                "stream_color": false,
+                "stream_create": false,
+                "stream_data": false,
+                "stream_edit": false,
+                "stream_events": false,
+                "stream_list": false,
+                "stream_muting": false,
+                "stream_popover": false,
+                "stream_sort": false,
+                "stream_ui_updates": false,
+                "StripeCheckout": false,
+                "submessage": false,
+                "subs": false,
+                "tab_bar": false,
+                "templates": false,
+                "tictactoe_widget": false,
+                "timerender": false,
+                "todo_widget": false,
+                "top_left_corner": false,
+                "topic_data": false,
+                "topic_generator": false,
+                "topic_list": false,
+                "topic_zoom": false,
+                "transmit": false,
+                "tutorial": false,
+                "typeahead_helper": false,
+                "typing": false,
+                "typing_data": false,
+                "typing_events": false,
+                "ui": false,
+                "ui_init": false,
+                "ui_report": false,
+                "ui_util": false,
+                "unread": false,
+                "unread_ops": false,
+                "unread_ui": false,
+                "upgrade": false,
+                "upload": false,
+                "upload_widget": false,
+                "user_events": false,
+                "user_groups": false,
+                "user_pill": false,
+                "user_search": false,
+                "user_status": false,
+                "user_status_ui": false,
+                "poll_widget": false,
+                "vdom": false,
+                "widgetize": false,
+                "zcommand": false,
+                "zform": false,
+                "zxcvbn": false
+            }
+        },
         {
             "files": [
                 "frontend_tests/casper_tests/*.js",