Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

typeahead_list_item.handlebars: Upgrade to font-awesome 4.7 icon prefixes. 

We also remove a CSS hack that was required because the original icon
was poorly centered.
This commit is contained in:
Aditya Bansal 2018-07-04 03:56:28 +05:30 committed by Tim Abbott
parent ae6c8692a9
commit 21b9e8dee1
3 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
frontend_tests/node_tests/composebox_typeahead.js
View File

@ -598,7 +598,7 @@ run_test('initialize', () => {
fake_this = { completing: 'mention', token: 'hamletcharacters' };
actual_value = options.highlighter.call(fake_this, hamletcharacters);
expected_value = ' <i class="typeahead-image icon icon-vector-group"></i>\n<strong>hamletcharacters</strong>&nbsp;&nbsp;\n<small class="autocomplete_secondary">Characters of Hamlet</small>\n';
expected_value = ' <i class="typeahead-image icon fa fa-group" aria-hidden="true"></i>\n<strong>hamletcharacters</strong>&nbsp;&nbsp;\n<small class="autocomplete_secondary">Characters of Hamlet</small>\n';
assert.equal(actual_value, expected_value);
// options.matcher()

5
static/styles/zulip.scss
View File

@ -1776,11 +1776,6 @@ blockquote p {
text-align: center;
}
.typeahead-image.icon {
/* This aligns the icon vertically. */
top: 0px;
}
.nav .dropdown-menu:after {
position: absolute;
width: 0px;

2
static/templates/typeahead_list_item.handlebars
View File

@ -14,7 +14,7 @@
{{/if}}
{{else}}
{{#if is_user_group}}
<i class="typeahead-image icon icon-vector-group"></i>
<i class="typeahead-image icon fa fa-group" aria-hidden="true"></i>
{{/if}}
{{/if}}
{{/if}}