Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

billing: Add test for exception during initial upgrade.

This commit is contained in:
Vishnu Ks 2018-10-22 16:11:14 +05:30 committed by Rishi Gupta
parent a7f4ea4b2c
commit 20de90066b
2 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
corporate/tests/test_stripe.py
View File

@ -413,6 +413,20 @@ class StripeTest(ZulipTestCase):
self.assert_in_success_response(["Upgrade to Zulip Standard"], response) self.assert_in_success_response(["Upgrade to Zulip Standard"], response)
self.assertEqual(response['error_description'], 'tampered plan') self.assertEqual(response['error_description'], 'tampered plan')
@patch("corporate.lib.stripe.billing_logger.error")
def test_upgrade_with_uncaught_exception(self, mock1: Mock) -> None:
self.login(self.example_email("hamlet"))
with patch("corporate.views.process_initial_upgrade", side_effect=Exception):
response = self.client_post("/upgrade/", {
'stripeToken': self.token,
'signed_seat_count': self.signed_seat_count,
'salt': self.salt,
'plan': Plan.CLOUD_ANNUAL
})
self.assert_in_success_response(["Upgrade to Zulip Standard",
"Something went wrong. Please contact"], response)
self.assertEqual(response['error_description'], 'uncaught exception during upgrade')
@patch("stripe.Customer.retrieve", side_effect=mock_customer_with_subscription) @patch("stripe.Customer.retrieve", side_effect=mock_customer_with_subscription)
@patch("stripe.Invoice.upcoming", side_effect=mock_upcoming_invoice) @patch("stripe.Invoice.upcoming", side_effect=mock_upcoming_invoice)
def test_billing_home(self, mock_upcoming_invoice: Mock, def test_billing_home(self, mock_upcoming_invoice: Mock,

1
corporate/views.py
View File

@ -63,6 +63,7 @@ def initial_upgrade(request: HttpRequest) -> HttpResponse:
except Exception as e: except Exception as e:
billing_logger.exception("Uncaught exception in billing: %s" % (e,)) billing_logger.exception("Uncaught exception in billing: %s" % (e,))
error_message = BillingError.CONTACT_SUPPORT error_message = BillingError.CONTACT_SUPPORT
error_description = "uncaught exception during upgrade"
else: else:
return HttpResponseRedirect(reverse('corporate.views.billing_home')) return HttpResponseRedirect(reverse('corporate.views.billing_home'))