billing: Use mock_stripe in test_downgrade.

corporate/tests/test_stripe.py

@@ -771,33 +771,56 @@ class StripeTest(ZulipTestCase):
         upcoming_invoice = stripe.Invoice.upcoming(customer=stripe_customer.id)
         self.assertEqual(upcoming_invoice.amount_due, get_seat_count(user.realm) * 80 * 75)
 
-    @patch("stripe.Subscription.delete")
+    # Tests upgrade followed by immediate downgrade. Doesn't test the
-    @patch("stripe.Customer.save")
+    # calculations for how much credit they should get if they had the
-    @patch("stripe.Invoice.upcoming", side_effect=mock_invoice_preview_for_downgrade())
+    # subscription for more than 0 time.
-    @patch("stripe.Customer.retrieve", side_effect=mock_customer_with_subscription)
+    @mock_stripe("Customer.create", "Customer.retrieve", "Customer.save", "Invoice.upcoming",
-    def test_downgrade(self, mock_retrieve_customer: Mock, mock_upcoming_invoice: Mock,
+                 "Subscription.create", "Subscription.retrieve", "Subscription.save",
-                       mock_save_customer: Mock, mock_delete_subscription: Mock) -> None:
+                 "Subscription.delete", "Token.create")
-        realm = get_realm('zulip')
+    def test_downgrade(self, mock9: Mock, mock8: Mock, mock7: Mock, mock6: Mock, mock5: Mock,
-        realm.has_seat_based_plan = True
+                       mock4: Mock, mock3: Mock, mock2: Mock, mock1: Mock) -> None:
-        realm.plan_type = Realm.STANDARD
-        realm.save(update_fields=['has_seat_based_plan', 'plan_type'])
-        Customer.objects.create(
-            realm=realm, stripe_customer_id=self.stripe_customer_id, has_billing_relationship=True)
         user = self.example_user('iago')
         self.login(user.email)
+        self.client_post("/upgrade/", {'stripeToken': stripe_create_token().id,
+                                       'signed_seat_count': self.signed_seat_count,
+                                       'salt': self.salt,
+                                       'plan': Plan.CLOUD_ANNUAL,
+                                       'billing_modality': 'charge_automatically'})
+        realm = get_realm('zulip')
+        self.assertEqual(realm.has_seat_based_plan, True)
+        self.assertEqual(realm.plan_type, Realm.STANDARD)
+        RealmAuditLog.objects.filter(realm=realm).delete()
+
+        stripe_customer = stripe_get_customer(Customer.objects.get(realm=user.realm).stripe_customer_id)
+        self.assertEqual(stripe_customer.account_balance, 0)
+        # Change subscription in Stripe, but don't pay for it
+        stripe_subscription = extract_current_subscription(stripe_customer)
+        stripe_subscription.quantity = 123
+        stripe.Subscription.save(stripe_subscription)
+
         response = self.client_post("/json/billing/downgrade", {})
         self.assert_json_success(response)
+        stripe_customer = stripe_get_customer(stripe_customer.id)
+        self.assertEqual(stripe_customer.account_balance, self.quantity * -8000)
+        self.assertIsNone(extract_current_subscription(stripe_customer))
+        stripe_subscription = stripe.Subscription.retrieve(stripe_subscription.id)
+        self.assertEqual(stripe_subscription.status, "canceled")
 
-        mock_delete_subscription.assert_called()
-        mock_save_customer.assert_called()
         realm = get_realm('zulip')
-        self.assertFalse(realm.has_seat_based_plan)
-        audit_log_entries = list(RealmAuditLog.objects.filter(acting_user=user)
-                                 .values_list('event_type', flat=True).order_by('id'))
-        # TODO: once we have proper mocks, test for event_time and extra_data in STRIPE_PLAN_CHANGED
-        self.assertEqual(audit_log_entries, [RealmAuditLog.STRIPE_PLAN_CHANGED,
-                                             RealmAuditLog.REALM_PLAN_TYPE_CHANGED])
         self.assertEqual(realm.plan_type, Realm.LIMITED)
+        self.assertFalse(realm.has_seat_based_plan)
+
+        audit_log_entries = list(RealmAuditLog.objects.filter(acting_user=user)
+                                 .values_list('event_type', 'event_time',
+                                              'requires_billing_update').order_by('id'))
+        self.assertEqual(audit_log_entries, [
+            (RealmAuditLog.STRIPE_PLAN_CHANGED,
+             timestamp_to_datetime(stripe_subscription.canceled_at), False),
+            (RealmAuditLog.REALM_PLAN_TYPE_CHANGED, Kandra(), False),
+        ])
+        self.assertEqual(ujson.loads(RealmAuditLog.objects.filter(
+            event_type=RealmAuditLog.STRIPE_PLAN_CHANGED).values_list('extra_data', flat=True).first()),
+            {'plan': None, 'quantity': 123})
 
     @patch("stripe.Customer.save")
     @patch("stripe.Customer.retrieve", side_effect=mock_create_customer)

stubs/stripe/__init__.pyi

@@ -83,6 +83,10 @@ class Subscription:
     def delete(subscription: Subscription) -> Subscription:
         ...
 
+    @staticmethod
+    def retrieve(subscription_id: str) -> Subscription:
+        ...
+
 class Source:
     id: str
     object: str