Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

dev_settings: Fix landing page not accessible on root domain. 

The ROOT_DOMAIN_LANDING_PAGE boolean setting is set based on
whether the root domain is a landing page or can host a realm.

We set it to False by default as we don't expect it to be used
by someone outside zulip.com (mentioned in 3173db37f7).

But the development environment uses the root domain 'zulipdev.com'
as landing page and the default realm is hosted at the subdomain
'zulip.zulipdev.com'.

So, this commit overrides the default value in 'dev_settings.py'.

Earlier, the zulip.com equivalent landing pages, including the
help center pages were not accessible in the dev environment.
This commit fixes those bugs.

Fixes #30750.
This commit is contained in:
Prakhar Pratyush 2024-09-02 17:25:45 +05:30 committed by Tim Abbott
parent a2ff4f52c4
commit 1e7468bbe5
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
zproject/dev_settings.py
View File

@ -217,3 +217,7 @@ ALLOW_GROUP_VALUED_SETTINGS = True
# This value needs to be lower in development than usual to allow
# for quicker testing of the feature.
RESOLVE_TOPIC_UNDO_GRACE_PERIOD_SECONDS = 5
# In a dev environment, 'zulipdev.com:9991' is used to access the landing page.
# See: https://zulip.readthedocs.io/en/latest/subsystems/realms.html#working-with-subdomains-in-development-environment
ROOT_DOMAIN_LANDING_PAGE = True

2
zproject/test_extra_settings.py
View File

@ -289,3 +289,5 @@ ALLOW_GROUP_VALUED_SETTINGS = True
RESOLVE_TOPIC_UNDO_GRACE_PERIOD_SECONDS = 0
KATEX_SERVER = False
ROOT_DOMAIN_LANDING_PAGE = False