Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

rendered_markdown: Convert module to typescript.

This commit is contained in:
evykassirer 2024-01-02 23:02:47 -08:00 committed by Tim Abbott
parent 4c5f115a6e
commit 1de36ec743
4 changed files with 61 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
web/src/message_edit_history.js
View File

@ -133,7 +133,7 @@ export function fetch_and_render_message_history(message) {
edited_messages: content_edit_history, edited_messages: content_edit_history,
}), }),
); );
// Pass the history through rendered_markdown.js // Pass the history through rendered_markdown.ts
// to update dynamic_elements in the content. // to update dynamic_elements in the content.
$("#message-history") $("#message-history")
.find(".rendered_markdown") .find(".rendered_markdown")

58
web/src/rendered_markdown.js → web/src/rendered_markdown.ts
View File

@ -1,6 +1,7 @@
import ClipboardJS from "clipboard"; import ClipboardJS from "clipboard";
import {isValid, parseISO} from "date-fns"; import {isValid, parseISO} from "date-fns";
import $ from "jquery"; import $ from "jquery";
import assert from "minimalistic-assert";
import copy_code_button from "../templates/copy_code_button.hbs"; import copy_code_button from "../templates/copy_code_button.hbs";
import render_markdown_timestamp from "../templates/markdown_timestamp.hbs"; import render_markdown_timestamp from "../templates/markdown_timestamp.hbs";
@ -10,6 +11,7 @@ import * as blueslip from "./blueslip";
import {show_copied_confirmation} from "./copied_tooltip"; import {show_copied_confirmation} from "./copied_tooltip";
import {$t, $t_html} from "./i18n"; import {$t, $t_html} from "./i18n";
import * as message_store from "./message_store"; import * as message_store from "./message_store";
import type {Message} from "./message_store";
import * as people from "./people"; import * as people from "./people";
import * as realm_playground from "./realm_playground"; import * as realm_playground from "./realm_playground";
import * as rows from "./rows"; import * as rows from "./rows";
@ -31,7 +33,7 @@ import * as util from "./util";
is being displayed. is being displayed.
*/ */
export function get_user_id_for_mention_button(elem) { export function get_user_id_for_mention_button(elem: HTMLElement): "*" | number | undefined {
const user_id_string = $(elem).attr("data-user-id"); const user_id_string = $(elem).attr("data-user-id");
// Handle legacy Markdown that was rendered before we cut // Handle legacy Markdown that was rendered before we cut
// over to using data-user-id. // over to using data-user-id.
@ -55,7 +57,7 @@ export function get_user_id_for_mention_button(elem) {
return undefined; return undefined;
} }
function get_user_group_id_for_mention_button(elem) { function get_user_group_id_for_mention_button(elem: HTMLElement): number | undefined {
const user_group_id = $(elem).attr("data-user-group-id"); const user_group_id = $(elem).attr("data-user-group-id");
if (user_group_id) { if (user_group_id) {
@ -65,7 +67,7 @@ function get_user_group_id_for_mention_button(elem) {
return undefined; return undefined;
} }
function get_message_for_message_content($content) { function get_message_for_message_content($content: JQuery): Message | undefined {
// TODO: This selector is designed to exclude drafts/scheduled // TODO: This selector is designed to exclude drafts/scheduled
// messages. Arguably those settings should be unconditionally // messages. Arguably those settings should be unconditionally
// marked with user-mention-me, but rows.id doesn't support // marked with user-mention-me, but rows.id doesn't support
@ -77,11 +79,16 @@ function get_message_for_message_content($content) {
return undefined; return undefined;
} }
const message_id = rows.id($message_row); const message_id = rows.id($message_row);
assert(message_id !== undefined);
return message_store.get(message_id); return message_store.get(message_id);
} }
// Helper function to update a mentioned user's name. // Helper function to update a mentioned user's name.
export function set_name_in_mention_element(element, name, user_id) { export function set_name_in_mention_element(
element: HTMLElement,
name: string,
user_id?: number,
): void {
if (user_id !== undefined && people.should_add_guest_user_indicator(user_id)) { if (user_id !== undefined && people.should_add_guest_user_indicator(user_id)) {
let display_text; let display_text;
if (!$(element).hasClass("silent")) { if (!$(element).hasClass("silent")) {
@ -100,7 +107,7 @@ export function set_name_in_mention_element(element, name, user_id) {
} }
} }
export const update_elements = ($content) => { export const update_elements = ($content: JQuery): void => {
// Set the rtl class if the text has an rtl direction // Set the rtl class if the text has an rtl direction
if (rtl.get_direction($content.text()) === "rtl") { if (rtl.get_direction($content.text()) === "rtl") {
$content.addClass("rtl"); $content.addClass("rtl");
@ -108,7 +115,7 @@ export const update_elements = ($content) => {
if (util.is_client_safari()) { if (util.is_client_safari()) {
// Without this video thumbnail doesn't load on Safari. // Without this video thumbnail doesn't load on Safari.
$content.find(".message_inline_video video").each(function () { $content.find<HTMLMediaElement>(".message_inline_video video").each(function () {
// On Safari, one needs to manually load video elements. // On Safari, one needs to manually load video elements.
// https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/load // https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/load
this.load(); this.load();
@ -116,7 +123,7 @@ export const update_elements = ($content) => {
} }
// personal and stream wildcard mentions // personal and stream wildcard mentions
$content.find(".user-mention").each(function () { $content.find(".user-mention").each(function (): void {
const user_id = get_user_id_for_mention_button(this); const user_id = get_user_id_for_mention_button(this);
const message = get_message_for_message_content($content); const message = get_message_for_message_content($content);
// We give special highlights to the mention buttons // We give special highlights to the mention buttons
@ -125,6 +132,7 @@ export const update_elements = ($content) => {
$(this).addClass("user-mention-me"); $(this).addClass("user-mention-me");
} }
if ( if (
user_id !== undefined &&
user_id !== "*" && user_id !== "*" &&
people.is_my_user_id(user_id) && people.is_my_user_id(user_id) &&
message && message &&
@ -158,7 +166,7 @@ export const update_elements = ($content) => {
} }
}); });
$content.find(".topic-mention").each(function () { $content.find(".topic-mention").each(function (): void {
const message = get_message_for_message_content($content); const message = get_message_for_message_content($content);
if (message && message.topic_wildcard_mentioned) { if (message && message.topic_wildcard_mentioned) {
@ -166,9 +174,13 @@ export const update_elements = ($content) => {
} }
}); });
$content.find(".user-group-mention").each(function () { $content.find(".user-group-mention").each(function (): void {
const user_group_id = get_user_group_id_for_mention_button(this); const user_group_id = get_user_group_id_for_mention_button(this);
let user_group; let user_group;
if (user_group_id === undefined) {
blueslip.info("Rendered undefined user group");
return;
}
try { try {
user_group = user_groups.get_user_group_from_id(user_group_id); user_group = user_groups.get_user_group_from_id(user_group_id);
} catch { } catch {
@ -192,8 +204,10 @@ export const update_elements = ($content) => {
} }
}); });
$content.find("a.stream").each(function () { $content.find("a.stream").each(function (): void {
const stream_id = Number.parseInt($(this).attr("data-stream-id"), 10); const stream_id_string = $(this).attr("data-stream-id");
if (stream_id_string !== undefined) {
const stream_id = Number.parseInt(stream_id_string, 10);
if (stream_id && !$(this).find(".highlight").length) { if (stream_id && !$(this).find(".highlight").length) {
// Display the current name for stream if it is not // Display the current name for stream if it is not
// being displayed in search highlight. // being displayed in search highlight.
@ -205,10 +219,13 @@ export const update_elements = ($content) => {
$(this).text("#" + stream_name); $(this).text("#" + stream_name);
} }
} }
}
}); });
$content.find("a.stream-topic").each(function () { $content.find("a.stream-topic").each(function (): void {
const stream_id = Number.parseInt($(this).attr("data-stream-id"), 10); const stream_id_string = $(this).attr("data-stream-id");
if (stream_id_string !== undefined) {
const stream_id = Number.parseInt(stream_id_string, 10);
if (stream_id && !$(this).find(".highlight").length) { if (stream_id && !$(this).find(".highlight").length) {
// Display the current name for stream if it is not // Display the current name for stream if it is not
// being displayed in search highlight. // being displayed in search highlight.
@ -221,9 +238,10 @@ export const update_elements = ($content) => {
$(this).text("#" + stream_name + text.slice(text.indexOf(" > "))); $(this).text("#" + stream_name + text.slice(text.indexOf(" > ")));
} }
} }
}
}); });
$content.find("time").each(function () { $content.find("time").each(function (): void {
// Populate each timestamp span with mentioned time // Populate each timestamp span with mentioned time
// in user's local time zone. // in user's local time zone.
const time_str = $(this).attr("datetime"); const time_str = $(this).attr("datetime");
@ -243,8 +261,10 @@ export const update_elements = ($content) => {
} }
}); });
$content.find("span.timestamp-error").each(function () { $content.find("span.timestamp-error").each(function (): void {
const [, time_str] = /^Invalid time format: (.*)$/.exec($(this).text()); const match_array = /^Invalid time format: (.*)$/.exec($(this).text());
assert(match_array !== null);
const [, time_str] = match_array;
const text = $t( const text = $t(
{defaultMessage: "Invalid time format: {timestamp}"}, {defaultMessage: "Invalid time format: {timestamp}"},
{timestamp: time_str}, {timestamp: time_str},
@ -252,7 +272,7 @@ export const update_elements = ($content) => {
$(this).text(text); $(this).text(text);
}); });
$content.find("div.spoiler-header").each(function () { $content.find("div.spoiler-header").each(function (): void {
// If a spoiler block has no header content, it should have a default header. // If a spoiler block has no header content, it should have a default header.
// We do this client side to allow for i18n by the client. // We do this client side to allow for i18n by the client.
if ($(this).html().trim().length === 0) { if ($(this).html().trim().length === 0) {
@ -267,7 +287,7 @@ export const update_elements = ($content) => {
// Display the view-code-in-playground and the copy-to-clipboard button inside the div.codehilite element, // Display the view-code-in-playground and the copy-to-clipboard button inside the div.codehilite element,
// and add a `zulip-code-block` class to it to detect it easily in `copy_and_paste.js`. // and add a `zulip-code-block` class to it to detect it easily in `copy_and_paste.js`.
$content.find("div.codehilite").each(function () { $content.find("div.codehilite").each(function (): void {
const $codehilite = $(this); const $codehilite = $(this);
const $pre = $codehilite.find("pre"); const $pre = $codehilite.find("pre");
const fenced_code_lang = $codehilite.data("code-language"); const fenced_code_lang = $codehilite.data("code-language");
@ -310,7 +330,7 @@ export const update_elements = ($content) => {
// Display emoji (including realm emoji) as text if // Display emoji (including realm emoji) as text if
// user_settings.emojiset is 'text'. // user_settings.emojiset is 'text'.
if (user_settings.emojiset === "text") { if (user_settings.emojiset === "text") {
$content.find(".emoji").replaceWith(function () { $content.find(".emoji").replaceWith(function (): string {
const text = $(this).attr("title"); const text = $(this).attr("title");
return ":" + text + ":"; return ":" + text + ":";
}); });

2
web/src/settings_playgrounds.js
View File

@ -128,7 +128,7 @@ function build_page() {
// FIXME: One thing to note here is that the "view code in playground" // FIXME: One thing to note here is that the "view code in playground"
// option for an already rendered code block (tagged with this newly added // option for an already rendered code block (tagged with this newly added
// language) would not be visible without a re-render. To fix this, we should // language) would not be visible without a re-render. To fix this, we should
// probably do some extraction in `rendered_markdown.js` which does a // probably do some extraction in `rendered_markdown.ts` which does a
// live-update of the `data-code-language` parameter in code blocks. Or change // live-update of the `data-code-language` parameter in code blocks. Or change
// how we do the HTML in the frontend so that the icon labels/behavior are // how we do the HTML in the frontend so that the icon labels/behavior are
// computed dynamically when you hover over the message based on configured // computed dynamically when you hover over the message based on configured

2
web/tests/spoilers.test.js
View File

@ -8,7 +8,7 @@ const $ = require("./lib/zjquery");
const spoilers = zrequire("spoilers"); const spoilers = zrequire("spoilers");
// This function is taken from rendered_markdown.js and slightly modified. // This function is taken from rendered_markdown.ts and slightly modified.
const $array = (array) => { const $array = (array) => {
const each = (func) => { const each = (func) => {
for (const [index, $elem] of array.entries()) { for (const [index, $elem] of array.entries()) {