Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

narrow_state: Extract cannot compute response.

This commit is contained in:
Aman Agrawal 2024-10-24 09:55:05 +00:00 committed by Tim Abbott
parent 88082bc25b
commit 1de1570a0c
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
web/src/narrow_state.ts
View File

@ -197,12 +197,11 @@ export function pm_emails_string(
export function get_first_unread_info(
current_filter: Filter | undefined = filter(),
): {flavor: "cannot_compute" | "not_found"} | {flavor: "found"; msg_id: number} {
const cannot_compute_response: {flavor: "cannot_compute"} = {flavor: "cannot_compute"};
if (current_filter === undefined) {
// we don't yet support the all-messages view
blueslip.error("unexpected call to get_first_unread_info");
return {
flavor: "cannot_compute",
};
return cannot_compute_response;
}
if (!current_filter.can_apply_locally()) {
@ -210,18 +209,14 @@ export function get_first_unread_info(
// that the client isn't privy to, we need to wait for the
// server to give us a definitive list of messages before
// deciding where we'll move the selection.
return {
flavor: "cannot_compute",
};
return cannot_compute_response;
}
const unread_ids = _possible_unread_message_ids(current_filter);
if (unread_ids === undefined) {
// _possible_unread_message_ids() only works for certain narrows
return {
flavor: "cannot_compute",
};
return cannot_compute_response;
}
const msg_id = current_filter.first_valid_id_from(unread_ids);