Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

provision: Run provision if provision check fails. 

This will helps us improve the developer experience
where they don't have to run provsion everytime.
This commit is contained in:
Riken Shah 2022-04-17 12:31:08 +00:00
parent b63757621a
commit 1d4ed408cb
1 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
tools/lib/test_script.py
View File

@ -42,7 +42,9 @@ dependencies than the version you provisioned last. This may
be ok, but it's likely that you either want to rebase your be ok, but it's likely that you either want to rebase your
branch on top of upstream/main or re-provision your machine. branch on top of upstream/main or re-provision your machine.
Do this: `./tools/provision` Don't worry we are running provision for you `./tools/provision`
If you wish to ignore auto provision use `--skip-provision-check`.
""" """
NEED_TO_UPGRADE = """ NEED_TO_UPGRADE = """
@ -50,7 +52,9 @@ The branch you are currently on has added dependencies beyond
what you last provisioned. Your command is likely to fail what you last provisioned. Your command is likely to fail
until you add dependencies by provisioning. until you add dependencies by provisioning.
Do this: `./tools/provision` Don't worry we are running provision for you `./tools/provision`
If you wish to ignore auto provision use `--skip-provision-check`.
""" """
@ -86,9 +90,15 @@ def assert_provisioning_status_ok(skip_provision_check: bool) -> None:
ok, msg = get_provisioning_status() ok, msg = get_provisioning_status()
if not ok: if not ok:
print(msg) print(msg)
print( p = subprocess.Popen(
"If you really know what you are doing, use --skip-provision-check to run anyway." ["./tools/provision"],
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
universal_newlines=True,
) )
output, _ = p.communicate()
if p.returncode != 0:
print(f"Running provision failed, here are the details \nOutput: {output}")
sys.exit(1) sys.exit(1)