From 1d2c3cec10f0928c0a93fd2c9082af79d52e233c Mon Sep 17 00:00:00 2001 From: Brock Whittaker Date: Wed, 8 Mar 2017 14:39:39 -0800 Subject: [PATCH] Fix: change mobile sidebar click target to call new popover function. This changes the click target that opens the mobile sidebar to call the new popover function in stream_popover rather than the old popovers object. --- static/js/click_handlers.js | 2 +- static/js/stream_popover.js | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/static/js/click_handlers.js b/static/js/click_handlers.js index 59f4855e81..7125733894 100644 --- a/static/js/click_handlers.js +++ b/static/js/click_handlers.js @@ -225,7 +225,7 @@ $(function () { var sidebarHidden = !$(".app-main .column-left").hasClass("expanded"); popovers.hide_all(); if (sidebarHidden) { - popovers.show_streamlist_sidebar(); + stream_popover.show_streamlist_sidebar(); } }); diff --git a/static/js/stream_popover.js b/static/js/stream_popover.js index 430a1599ff..feaf045993 100644 --- a/static/js/stream_popover.js +++ b/static/js/stream_popover.js @@ -32,7 +32,7 @@ exports.hide_topic_popover = function () { // These are the only two functions that is really shared by the // two popovers, so we could split out topic stuff to // another module pretty easily. -exports.resize_stream_list = function () { +exports.show_streamlist_sidebar = function () { $(".app-main .column-left").addClass("expanded"); resize.resize_page_components(); }; @@ -82,7 +82,7 @@ function build_stream_popover(e) { } popovers.hide_all(); - exports.resize_stream_list(); + exports.show_streamlist_sidebar(); var stream = $(elt).parents('li').attr('data-name'); @@ -130,7 +130,7 @@ function build_topic_popover(e) { } popovers.hide_all(); - exports.resize_stream_list(); + exports.show_streamlist_sidebar(); var is_muted = muting.is_topic_muted(stream_name, topic_name); var can_mute_topic = !is_muted;