Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Only update floating recipient bar at end of scroll. 

This makes scrolling much cheaper and reduces jerky scrolling.

(imported from commit 38b620bb13c498556a21962113a94e35a209d52b)
This commit is contained in:
Jessica McKellar 2013-02-18 14:37:17 -05:00
parent 2b7b39fe1f
commit 1b02928806
1 changed files with 25 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
zephyr/static/js/ui.js
View File

@ -270,8 +270,16 @@ $(function () {
} }
}); });
var old_label;
var is_floating_recipient_bar_showing = false; var is_floating_recipient_bar_showing = false;
function show_floating_recipient_bar() {
if (!is_floating_recipient_bar_showing) {
$(".floating_recipient_bar").css('visibility', 'visible');
is_floating_recipient_bar_showing = true;
}
}
var old_label;
function replace_floating_recipient_bar(desired_label) { function replace_floating_recipient_bar(desired_label) {
var new_label, other_label, header; var new_label, other_label, header;
if (desired_label !== old_label) { if (desired_label !== old_label) {
@ -296,10 +304,7 @@ function replace_floating_recipient_bar(desired_label) {
old_label = desired_label; old_label = desired_label;
} }
if (!is_floating_recipient_bar_showing) { show_floating_recipient_bar();
$(".floating_recipient_bar").css('visibility', 'visible');
is_floating_recipient_bar_showing = true;
}
} }
function hide_floating_recipient_bar() { function hide_floating_recipient_bar() {
@ -524,10 +529,11 @@ $(function () {
subs.subscribe_for_send(compose.stream_name(), $('#stream-nosub')); subs.subscribe_for_send(compose.stream_name(), $('#stream-nosub'));
}); });
$(window).scroll($.throttle(50, function (e) { function scroll_finished() {
show_floating_recipient_bar();
exports.update_floating_recipient_bar();
keep_pointer_in_view();
if ($('#home').hasClass('active')) { if ($('#home').hasClass('active')) {
keep_pointer_in_view();
exports.update_floating_recipient_bar();
if (viewport.scrollTop() === 0 && if (viewport.scrollTop() === 0 &&
have_scrolled_away_from_top) { have_scrolled_away_from_top) {
have_scrolled_away_from_top = false; have_scrolled_away_from_top = false;
@ -538,6 +544,17 @@ $(function () {
// When the window scrolls, it may cause some messages to go off the screen // When the window scrolls, it may cause some messages to go off the screen
notifications_bar.update(); notifications_bar.update();
} }
}
var scroll_timer;
function scroll_finish() {
clearTimeout(scroll_timer);
scroll_timer = setTimeout(scroll_finished, 100);
}
$(window).scroll($.throttle(50, function (e) {
hide_floating_recipient_bar();
scroll_finish();
})); }));
var throttled_mousewheelhandler = $.throttle(50, function (e, delta) { var throttled_mousewheelhandler = $.throttle(50, function (e, delta) {