Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

message_list_view: Use util.the for converting JQuery to HTMLElement.

This commit is contained in:
evykassirer 2024-08-21 16:32:24 -07:00 committed by Tim Abbott
parent 2f77463864
commit 1a204ff554
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
web/src/message_list_view.js
View File

@ -119,7 +119,7 @@ function analyze_edit_history(message, last_edit_timestr) {
function render_group_display_date(group, message_container) { function render_group_display_date(group, message_container) {
const time = new Date(message_container.msg.timestamp * 1000); const time = new Date(message_container.msg.timestamp * 1000);
const date_element = timerender.render_date(time)[0]; const date_element = util.the(timerender.render_date(time));
group.date = date_element.outerHTML; group.date = date_element.outerHTML;
} }
@ -153,7 +153,7 @@ function update_message_date_divider(opts) {
const curr_time = new Date(curr_msg_container.msg.timestamp * 1000); const curr_time = new Date(curr_msg_container.msg.timestamp * 1000);
curr_msg_container.want_date_divider = true; curr_msg_container.want_date_divider = true;
curr_msg_container.date_divider_html = timerender.render_date(curr_time)[0].outerHTML; curr_msg_container.date_divider_html = util.the(timerender.render_date(curr_time)).outerHTML;
} }
function set_timestr(message_container) { function set_timestr(message_container) {
@ -258,7 +258,7 @@ function maybe_restore_focus_to_message_edit_form() {
} }
$message_edit_content.trigger("focus"); $message_edit_content.trigger("focus");
$message_edit_content[0].setSelectionRange( util.the($message_edit_content).setSelectionRange(
message_id_to_focus_after_processing_message_events.selectionStart, message_id_to_focus_after_processing_message_events.selectionStart,
message_id_to_focus_after_processing_message_events.selectionEnd, message_id_to_focus_after_processing_message_events.selectionEnd,
); );
@ -391,7 +391,7 @@ export class MessageListView {
} }
if (last_edit_timestamp !== undefined) { if (last_edit_timestamp !== undefined) {
const last_edit_time = new Date(last_edit_timestamp * 1000); const last_edit_time = new Date(last_edit_timestamp * 1000);
let date = timerender.render_date(last_edit_time)[0].textContent; let date = util.the(timerender.render_date(last_edit_time)).textContent;
// If the date is today or yesterday, we don't want to show the date as capitalized. // If the date is today or yesterday, we don't want to show the date as capitalized.
// Thus, we need to check if the date string contains a digit or not using regex, // Thus, we need to check if the date string contains a digit or not using regex,
// since any other date except today/yesterday will contain a digit. // since any other date except today/yesterday will contain a digit.
@ -1768,7 +1768,7 @@ export class MessageListView {
$message_row = $sticky_header.nextAll(".message_row").first(); $message_row = $sticky_header.nextAll(".message_row").first();
} else { } else {
dom_updates.add_classes.push({$element: $sticky_header, class: "sticky_header"}); dom_updates.add_classes.push({$element: $sticky_header, class: "sticky_header"});
const sticky_header_props = $sticky_header[0].getBoundingClientRect(); const sticky_header_props = util.the($sticky_header).getBoundingClientRect();
/* date separator starts to be hidden at this height difference. */ /* date separator starts to be hidden at this height difference. */
const date_separator_padding = 7; const date_separator_padding = 7;
const sticky_header_bottom = sticky_header_props.top + sticky_header_props.height; const sticky_header_bottom = sticky_header_props.top + sticky_header_props.height;