From 18ce4aed8bd14bbcd4aef892e18a5def9175dad2 Mon Sep 17 00:00:00 2001
From: Anders Kaseorg <anders@zulip.com>
Date: Tue, 4 Aug 2020 15:43:16 -0700
Subject: [PATCH] styles: Enable stylelint font-family-name-quotes rule.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
---
 static/styles/alerts.scss           | 2 +-
 static/styles/app_components.scss   | 2 +-
 static/styles/portico/billing.scss  | 2 +-
 static/styles/portico/markdown.scss | 4 ++--
 static/styles/settings.scss         | 2 +-
 static/styles/subscriptions.scss    | 2 +-
 stylelint.config.js                 | 3 +++
 7 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/static/styles/alerts.scss b/static/styles/alerts.scss
index 3592c21851..91bd97ffd9 100644
--- a/static/styles/alerts.scss
+++ b/static/styles/alerts.scss
@@ -175,7 +175,7 @@ $alert-error-red: hsl(0, 80%, 40%);
             top: 10px;
             left: 12px;
 
-            font-family: "FontAwesome";
+            font-family: FontAwesome;
             font-size: 1.3em;
             content: "\f071";
 
diff --git a/static/styles/app_components.scss b/static/styles/app_components.scss
index 86888e44d0..9a00aa2b84 100644
--- a/static/styles/app_components.scss
+++ b/static/styles/app_components.scss
@@ -473,7 +473,7 @@
         display: inline;
         margin-right: 8px;
 
-        font-family: FontAwesome, "Yantramanav", Source Sans Pro;
+        font-family: FontAwesome, Yantramanav, "Source Sans Pro";
         font-weight: 600;
     }
 }
diff --git a/static/styles/portico/billing.scss b/static/styles/portico/billing.scss
index 3510421fc0..cb6bd3bbc4 100644
--- a/static/styles/portico/billing.scss
+++ b/static/styles/portico/billing.scss
@@ -1,5 +1,5 @@
 .billing-upgrade-page {
-    font-family: Source Sans Pro, Helvetica, Arial, sans-serif;
+    font-family: "Source Sans Pro", Helvetica, Arial, sans-serif;
     background-color: hsl(0, 0%, 98%);
     height: 100vh;
 
diff --git a/static/styles/portico/markdown.scss b/static/styles/portico/markdown.scss
index e32210b64a..b83a617551 100644
--- a/static/styles/portico/markdown.scss
+++ b/static/styles/portico/markdown.scss
@@ -241,14 +241,14 @@
     .tip::before {
         display: inline;
         content: "\f0eb   Tip:  ";
-        font-family: FontAwesome, "Yantramanav", Source Sans Pro;
+        font-family: FontAwesome, Yantramanav, "Source Sans Pro";
         font-weight: 600;
     }
 
     .keyboard_tip::before {
         display: inline;
         content: "\f11c   Keyboard Shortcut:  ";
-        font-family: FontAwesome, "Yantramanav", Source Sans Pro;
+        font-family: FontAwesome, Yantramanav, "Source Sans Pro";
         font-weight: 600;
     }
 
diff --git a/static/styles/settings.scss b/static/styles/settings.scss
index 6b4b8f297e..06e95e146b 100644
--- a/static/styles/settings.scss
+++ b/static/styles/settings.scss
@@ -896,7 +896,7 @@ input[type="checkbox"] {
     }
 
     .api_key .api-key-value-and-button {
-        font-family: "Inconsolata", Menlo, monospace;
+        font-family: Inconsolata, Menlo, monospace;
         font-size: 0.85em;
         display: flex;
     }
diff --git a/static/styles/subscriptions.scss b/static/styles/subscriptions.scss
index 4eb16690b8..2f17557e93 100644
--- a/static/styles/subscriptions.scss
+++ b/static/styles/subscriptions.scss
@@ -943,7 +943,7 @@ form#add_new_subscription {
 
         &:empty::before {
             content: "\f040";
-            font-family: "FontAwesome";
+            font-family: FontAwesome;
             font-size: 0.8rem;
             font-weight: normal;
         }
diff --git a/stylelint.config.js b/stylelint.config.js
index 64c1cb176c..6d85f1417c 100644
--- a/stylelint.config.js
+++ b/stylelint.config.js
@@ -19,6 +19,9 @@ module.exports = {
         "declaration-empty-line-before": null,
         "length-zero-no-unit": null,
 
+        // Additional stylistic rules
+        "font-family-name-quotes": "always-where-recommended",
+
         // Limit language features
         "color-no-hex": true,
         "color-named": "never",