Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

node_tests: Revert wrong conversion of some functions to arrows. 

‘function’ and ‘=>’ are not equivalent because they bind ‘this’
differently.  For these functions, the ‘function’ semantics are
intentional.

This reverts part of commit 1a241cef88
(#17388).

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg 2021-02-23 11:32:35 -08:00
parent e43e0cb9bb
commit 174fa0a331
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
frontend_tests/node_tests/compose_ui.js
View File

@ -39,7 +39,7 @@ function make_textbox(s) {
widget.s = s; widget.s = s;
widget.focused = false; widget.focused = false;
widget.caret = (arg) => { widget.caret = function (arg) {
if (typeof arg === "number") { if (typeof arg === "number") {
widget.pos = arg; widget.pos = arg;
return this; return this;
@ -58,7 +58,7 @@ function make_textbox(s) {
return widget.pos; return widget.pos;
}; };
widget.val = (new_val) => { widget.val = function (new_val) {
if (new_val) { if (new_val) {
widget.s = new_val; widget.s = new_val;
return this; return this;
@ -66,7 +66,7 @@ function make_textbox(s) {
return widget.s; return widget.s;
}; };
widget.trigger = (type) => { widget.trigger = function (type) {
if (type === "focus") { if (type === "focus") {
widget.focused = true; widget.focused = true;
} else if (type === "blur") { } else if (type === "blur") {
@ -95,7 +95,7 @@ run_test("autosize_textarea", (override) => {
run_test("insert_syntax_and_focus", () => { run_test("insert_syntax_and_focus", () => {
$("#compose-textarea").val("xyz "); $("#compose-textarea").val("xyz ");
$("#compose-textarea").caret = (syntax) => { $("#compose-textarea").caret = function (syntax) {
if (syntax !== undefined) { if (syntax !== undefined) {
$("#compose-textarea").val($("#compose-textarea").val() + syntax); $("#compose-textarea").val($("#compose-textarea").val() + syntax);
return this; return this;

2
frontend_tests/node_tests/composebox_typeahead.js
View File

@ -313,7 +313,7 @@ run_test("content_typeahead_selected", () => {
}; };
let caret_called1 = false; let caret_called1 = false;
let caret_called2 = false; let caret_called2 = false;
fake_this.$element.caret = (...args) => { fake_this.$element.caret = function (...args) {
if (args.length === 0) { if (args.length === 0) {
// .caret() used in split_at_cursor // .caret() used in split_at_cursor
caret_called1 = true; caret_called1 = true;