From 17192ed46b6b231ce62aafb29e90ecb62309011e Mon Sep 17 00:00:00 2001 From: Anders Kaseorg Date: Mon, 9 Sep 2019 13:06:07 -0700 Subject: [PATCH] Revert "provision: Give concrete NFS error message on older OSX versions." MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 073ecaac66f277b7eef74f0b5610352d55e4d5a9 (#9365). This exception handler was overly broad in catching all `OSError`s, and it made debugging harder by hiding the actual exception. Furthermore, we no longer use NFS (#12963), and we’re now getting reports of Windows users running into this message. Signed-off-by: Anders Kaseorg --- tools/setup/generate_zulip_bots_static_files.py | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/tools/setup/generate_zulip_bots_static_files.py b/tools/setup/generate_zulip_bots_static_files.py index 99237e6366..c1407459cb 100755 --- a/tools/setup/generate_zulip_bots_static_files.py +++ b/tools/setup/generate_zulip_bots_static_files.py @@ -16,13 +16,7 @@ def generate_zulip_bots_static_files() -> None: bots_dir = 'static/generated/bots' if os.path.isdir(bots_dir): # delete old static files, they could be outdated - try: - shutil.rmtree(bots_dir) - except OSError: - print("There was a permission error with Vagrant's NFS file sharing on old versions of " + - "OSX. You can fix this by upgrading to the latest OSX High Sierra, or work around it " + - "by giving read/write permissions to your /zulip folder to everyone.") - sys.exit(1) + shutil.rmtree(bots_dir) os.makedirs(bots_dir, exist_ok=True)