From 16bf9e760074d41d0a0df4f882c755deff7f03c1 Mon Sep 17 00:00:00 2001
From: Sahil Batra <sahil@zulip.com>
Date: Mon, 7 Aug 2023 13:02:19 +0530
Subject: [PATCH] templates: Remove table-condensed class for <table> elements.

The table-condensed class was used by bootstrap to add padding
to the table cells. But since we want padding in cells for all
tables, we added the padding CSS to the other existing CSS for
tables while removing the bootstrap CSS for tables and
"table-condensed" is not required anymore.
---
 web/templates/keyboard_shortcuts.hbs           | 18 +++++++++---------
 web/templates/markdown_help.hbs                |  2 +-
 web/templates/search_operators.hbs             |  2 +-
 web/templates/settings/alert_word_settings.hbs |  2 +-
 .../settings/attachments_settings.hbs          |  2 +-
 web/templates/settings/bot_list_admin.hbs      |  2 +-
 web/templates/settings/data_exports_admin.hbs  |  2 +-
 .../settings/deactivated_users_admin.hbs       |  2 +-
 .../settings/default_streams_list_admin.hbs    |  2 +-
 .../settings/emoji_settings_admin.hbs          |  2 +-
 web/templates/settings/invites_list_admin.hbs  |  2 +-
 .../settings/linkifier_settings_admin.hbs      |  2 +-
 .../settings/muted_users_settings.hbs          |  2 +-
 .../settings/notification_settings.hbs         |  2 +-
 .../settings/playground_settings_admin.hbs     |  2 +-
 .../settings/profile_field_settings_admin.hbs  |  2 +-
 web/templates/settings/realm_domains_modal.hbs |  2 +-
 web/templates/settings/user_list_admin.hbs     |  2 +-
 .../settings/user_topics_settings.hbs          |  2 +-
 19 files changed, 27 insertions(+), 27 deletions(-)

diff --git a/web/templates/keyboard_shortcuts.hbs b/web/templates/keyboard_shortcuts.hbs
index 18f04fc912..9b2dd3eb32 100644
--- a/web/templates/keyboard_shortcuts.hbs
+++ b/web/templates/keyboard_shortcuts.hbs
@@ -2,7 +2,7 @@
   aria-label="{{t 'Keyboard shortcuts' }}">
     <div class="modal-body" data-simplebar data-simplebar-auto-hide="false">
         <div>
-            <table class="hotkeys_table table table-striped table-bordered table-condensed">
+            <table class="hotkeys_table table table-striped table-bordered">
                 <thead>
                     <tr>
                         <th colspan="2">{{t "The basics" }}</th>
@@ -59,7 +59,7 @@
             </table>
         </div>
         <div>
-            <table class="hotkeys_table table table-striped table-bordered table-condensed">
+            <table class="hotkeys_table table table-striped table-bordered">
                 <thead>
                     <tr>
                         <th colspan="2">{{t 'Navigation' }}</th>
@@ -112,7 +112,7 @@
             </table>
         </div>
         <div>
-            <table class="hotkeys_table table table-striped table-bordered table-condensed">
+            <table class="hotkeys_table table table-striped table-bordered">
                 <thead>
                     <tr>
                         <th colspan="2">{{t 'Composing messages' }}</th>
@@ -157,7 +157,7 @@
             </table>
         </div>
         <div>
-            <table class="hotkeys_table table table-striped table-bordered table-condensed">
+            <table class="hotkeys_table table table-striped table-bordered">
                 <thead>
                     <tr>
                         <th colspan="2">{{t 'Narrowing' }}</th>
@@ -202,7 +202,7 @@
             </table>
         </div>
         <div>
-            <table class="hotkeys_table table table-striped table-bordered table-condensed">
+            <table class="hotkeys_table table table-striped table-bordered">
                 <thead>
                     <tr>
                         <th colspan="2">{{t 'Message actions' }}</th>
@@ -261,7 +261,7 @@
             </table>
         </div>
         <div>
-            <table class="hotkeys_table table table-striped table-bordered table-condensed">
+            <table class="hotkeys_table table table-striped table-bordered">
                 <thead>
                     <tr>
                         <th colspan="2">{{t 'Recent conversations' }}</th>
@@ -278,7 +278,7 @@
             </table>
         </div>
         <div>
-            <table class="hotkeys_table table table-striped table-bordered table-condensed">
+            <table class="hotkeys_table table table-striped table-bordered">
                 <thead>
                     <tr>
                         <th colspan="2">{{t 'Drafts' }}</th>
@@ -299,7 +299,7 @@
             </table>
         </div>
         <div>
-            <table class="hotkeys_table table table-striped table-bordered table-condensed">
+            <table class="hotkeys_table table table-striped table-bordered">
                 <thead>
                     <tr>
                         <th colspan="2">{{t 'Menus' }}</th>
@@ -324,7 +324,7 @@
             </table>
         </div>
         <div>
-            <table class="hotkeys_table table table-striped table-bordered table-condensed">
+            <table class="hotkeys_table table table-striped table-bordered">
                 <thead>
                     <tr>
                         <th colspan="2">{{t 'Streams settings' }}</th>
diff --git a/web/templates/markdown_help.hbs b/web/templates/markdown_help.hbs
index 7438cf17f2..13355f66af 100644
--- a/web/templates/markdown_help.hbs
+++ b/web/templates/markdown_help.hbs
@@ -2,7 +2,7 @@
   aria-label="{{t 'Message formatting' }}">
     <div class="modal-body" data-simplebar data-simplebar-auto-hide="false">
         <div id="markdown-instructions">
-            <table class="table table-striped table-condensed table-rounded table-bordered help-table">
+            <table class="table table-striped table-rounded table-bordered help-table">
                 <thead>
                     <tr>
                         <th>{{t "You type" }}</th>
diff --git a/web/templates/search_operators.hbs b/web/templates/search_operators.hbs
index b4bf2687f7..05c6a57d4c 100644
--- a/web/templates/search_operators.hbs
+++ b/web/templates/search_operators.hbs
@@ -1,7 +1,7 @@
 <div class="overlay-modal hide" id="search-operators" tabindex="-1" role="dialog" aria-label="{{t 'Search filters' }}">
     <div class="modal-body" data-simplebar data-simplebar-auto-hide="false">
         <div id="operators-instructions">
-            <table class="table table-striped table-condensed table-rounded table-bordered help-table">
+            <table class="table table-striped table-rounded table-bordered help-table">
                 <thead>
                     <tr>
                         <th>{{t "Filter" }}</th>
diff --git a/web/templates/settings/alert_word_settings.hbs b/web/templates/settings/alert_word_settings.hbs
index 72f4d7cd41..883aeba6c5 100644
--- a/web/templates/settings/alert_word_settings.hbs
+++ b/web/templates/settings/alert_word_settings.hbs
@@ -18,7 +18,7 @@
         <span class="alert_word_status_text"></span>
     </div>
     <div class="progressive-table-wrapper" data-simplebar>
-        <table class="table table-condensed table-striped wrapped-table">
+        <table class="table table-striped wrapped-table">
             <thead class="table-sticky-headers">
                 <th data-sort="alphabetic" data-sort-prop="word">{{t "Word" }}</th>
                 <th class="actions">{{t "Actions" }}</th>
diff --git a/web/templates/settings/attachments_settings.hbs b/web/templates/settings/attachments_settings.hbs
index 6b4c02dcd6..f0282c0d80 100644
--- a/web/templates/settings/attachments_settings.hbs
+++ b/web/templates/settings/attachments_settings.hbs
@@ -7,7 +7,7 @@
     <div class="clear-float"></div>
     <div class="alert" id="delete-upload-status"></div>
     <div class="progressive-table-wrapper" data-simplebar>
-        <table class="table table-condensed table-striped wrapped-table">
+        <table class="table table-striped wrapped-table">
             <thead class="table-sticky-headers">
                 <th data-sort="alphabetic" data-sort-prop="name" class="upload-file-name">{{t "File" }}</th>
                 <th class="active upload-date" data-sort="numeric" data-sort-prop="create_time">{{t "Date uploaded" }}</th>
diff --git a/web/templates/settings/bot_list_admin.hbs b/web/templates/settings/bot_list_admin.hbs
index 68cc9ad264..4dab5591e4 100644
--- a/web/templates/settings/bot_list_admin.hbs
+++ b/web/templates/settings/bot_list_admin.hbs
@@ -12,7 +12,7 @@
     </div>
 
     <div class="progressive-table-wrapper" data-simplebar>
-        <table class="table table-condensed table-striped wrapped-table">
+        <table class="table table-striped wrapped-table">
             <thead class="table-sticky-headers">
                 <th class="active" data-sort="alphabetic" data-sort-prop="full_name">{{t "Name" }}</th>
                 <th data-sort="email">{{t "Email" }}</th>
diff --git a/web/templates/settings/data_exports_admin.hbs b/web/templates/settings/data_exports_admin.hbs
index 85ed7baa46..c1a03acbd0 100644
--- a/web/templates/settings/data_exports_admin.hbs
+++ b/web/templates/settings/data_exports_admin.hbs
@@ -37,7 +37,7 @@
     </div>
 
     <div class="progressive-table-wrapper" data-simplebar>
-        <table class="table table-condensed table-striped wrapped-table admin_exports_table">
+        <table class="table table-striped wrapped-table admin_exports_table">
             <thead class="table-sticky-headers">
                 <th class="active" data-sort="user">{{t "Requesting user" }}</th>
                 <th data-sort="numeric" data-sort-prop="export_time">{{t "Time" }}</th>
diff --git a/web/templates/settings/deactivated_users_admin.hbs b/web/templates/settings/deactivated_users_admin.hbs
index e7701bee26..9b30bab840 100644
--- a/web/templates/settings/deactivated_users_admin.hbs
+++ b/web/templates/settings/deactivated_users_admin.hbs
@@ -10,7 +10,7 @@
     </div>
 
     <div class="progressive-table-wrapper" data-simplebar>
-        <table class="table table-condensed table-striped wrapped-table">
+        <table class="table table-striped wrapped-table">
             <thead class="table-sticky-headers">
                 <th class="active" data-sort="alphabetic" data-sort-prop="full_name">{{t "Name" }}</th>
                 <th {{#if allow_sorting_deactivated_users_list_by_email}}data-sort="email"{{/if}}>{{t "Email" }}</th>
diff --git a/web/templates/settings/default_streams_list_admin.hbs b/web/templates/settings/default_streams_list_admin.hbs
index 3477a22d95..4355260eae 100644
--- a/web/templates/settings/default_streams_list_admin.hbs
+++ b/web/templates/settings/default_streams_list_admin.hbs
@@ -12,7 +12,7 @@
     </div>
 
     <div class="progressive-table-wrapper" data-simplebar>
-        <table class="table table-condensed table-striped wrapped-table">
+        <table class="table table-striped wrapped-table">
             <thead class="table-sticky-headers">
                 <th class="active" data-sort="alphabetic" data-sort-prop="name">{{t "Name" }}</th>
                 {{#if is_admin}}
diff --git a/web/templates/settings/emoji_settings_admin.hbs b/web/templates/settings/emoji_settings_admin.hbs
index ceef112663..2864faa22f 100644
--- a/web/templates/settings/emoji_settings_admin.hbs
+++ b/web/templates/settings/emoji_settings_admin.hbs
@@ -15,7 +15,7 @@
           aria-label="{{t 'Filter emoji' }}"/>
     </div>
     <div class="progressive-table-wrapper" data-simplebar>
-        <table class="table table-condensed table-striped wrapped-table admin_emoji_table">
+        <table class="table table-striped wrapped-table admin_emoji_table">
             <thead class="table-sticky-headers">
                 <th class="active" data-sort="alphabetic" data-sort-prop="name">{{t "Name" }}</th>
                 <th class="image">{{t "Image" }}</th>
diff --git a/web/templates/settings/invites_list_admin.hbs b/web/templates/settings/invites_list_admin.hbs
index 41ba1ad2c2..f475864b35 100644
--- a/web/templates/settings/invites_list_admin.hbs
+++ b/web/templates/settings/invites_list_admin.hbs
@@ -14,7 +14,7 @@
     </div>
 
     <div class="progressive-table-wrapper" data-simplebar>
-        <table class="table table-condensed table-striped">
+        <table class="table table-striped">
             <thead class="table-sticky-headers">
                 <th class="active" data-sort="invitee">{{t "Invitee" }}</th>
                 {{#if is_admin }}
diff --git a/web/templates/settings/linkifier_settings_admin.hbs b/web/templates/settings/linkifier_settings_admin.hbs
index 7302508923..492d2ea6d4 100644
--- a/web/templates/settings/linkifier_settings_admin.hbs
+++ b/web/templates/settings/linkifier_settings_admin.hbs
@@ -63,7 +63,7 @@
         </div>
 
         <div class="progressive-table-wrapper" data-simplebar>
-            <table class="table table-condensed table-striped wrapped-table admin_linkifiers_table">
+            <table class="table table-striped wrapped-table admin_linkifiers_table">
                 <thead class="table-sticky-headers">
                     <th>{{t "Pattern" }}</th>
                     <th>{{t "URL template" }}</th>
diff --git a/web/templates/settings/muted_users_settings.hbs b/web/templates/settings/muted_users_settings.hbs
index 1757a45b69..c72689cb63 100644
--- a/web/templates/settings/muted_users_settings.hbs
+++ b/web/templates/settings/muted_users_settings.hbs
@@ -4,7 +4,7 @@
         <input id="muted_users_search" class="search filter_text_input" type="text" placeholder="{{t 'Filter muted users' }}" aria-label="{{t 'Filter muted users' }}"/>
     </div>
     <div class="progressive-table-wrapper" data-simplebar>
-        <table class="table table-condensed table-striped wrapped-table">
+        <table class="table table-striped wrapped-table">
             <thead class="table-sticky-headers">
                 <th data-sort="alphabetic" data-sort-prop="user_name">{{t "User" }}</th>
                 <th data-sort="numeric" data-sort-prop="date_muted">{{t "Date muted" }}</th>
diff --git a/web/templates/settings/notification_settings.hbs b/web/templates/settings/notification_settings.hbs
index 7583a772cc..5d027718de 100644
--- a/web/templates/settings/notification_settings.hbs
+++ b/web/templates/settings/notification_settings.hbs
@@ -5,7 +5,7 @@
             {{> settings_save_discard_widget section_name="general-notify-settings" show_only_indicator=(not for_realm_settings) }}
         </div>
         <p>{{t "Configure how Zulip notifies you about new messages." }}</p>
-        <table class="notification-table table table-condensed table-bordered wrapped-table">
+        <table class="notification-table table table-bordered wrapped-table">
             <thead>
                 <tr>
                     <th rowspan="2" width="30%"></th>
diff --git a/web/templates/settings/playground_settings_admin.hbs b/web/templates/settings/playground_settings_admin.hbs
index a303cfac72..d211c3647c 100644
--- a/web/templates/settings/playground_settings_admin.hbs
+++ b/web/templates/settings/playground_settings_admin.hbs
@@ -69,7 +69,7 @@
         </div>
 
         <div class="progressive-table-wrapper" data-simplebar>
-            <table class="table table-condensed table-striped wrapped-table admin_playgrounds_table">
+            <table class="table table-striped wrapped-table admin_playgrounds_table">
                 <thead class="table-sticky-headers">
                     <th class="active" data-sort="alphabetic" data-sort-prop="pygments_language">{{t "Language" }}</th>
                     <th data-sort="alphabetic" data-sort-prop="name">{{t "Name" }}</th>
diff --git a/web/templates/settings/profile_field_settings_admin.hbs b/web/templates/settings/profile_field_settings_admin.hbs
index eb7a42d974..5c74ac1074 100644
--- a/web/templates/settings/profile_field_settings_admin.hbs
+++ b/web/templates/settings/profile_field_settings_admin.hbs
@@ -7,7 +7,7 @@
         {{/if}}
     </div>
     <div class="admin-table-wrapper">
-        <table class="table table-condensed table-striped admin_profile_fields_table">
+        <table class="table table-striped admin_profile_fields_table">
             <thead>
                 <tr>
                     <th>{{t "Label" }}</th>
diff --git a/web/templates/settings/realm_domains_modal.hbs b/web/templates/settings/realm_domains_modal.hbs
index b54f765f8d..9948e15b77 100644
--- a/web/templates/settings/realm_domains_modal.hbs
+++ b/web/templates/settings/realm_domains_modal.hbs
@@ -1,4 +1,4 @@
-<table class="table table-condensed table-stripped new-style" id="realm_domains_table">
+<table class="table table-stripped new-style" id="realm_domains_table">
     <thead>
         <th>{{t "Domain" }}</th>
         <th>{{t "Allow subdomains"}}</th>
diff --git a/web/templates/settings/user_list_admin.hbs b/web/templates/settings/user_list_admin.hbs
index f63e79fab7..bcc3e6234e 100644
--- a/web/templates/settings/user_list_admin.hbs
+++ b/web/templates/settings/user_list_admin.hbs
@@ -9,7 +9,7 @@
     </div>
 
     <div class="progressive-table-wrapper" data-simplebar>
-        <table class="table table-condensed table-striped wrapped-table">
+        <table class="table table-striped wrapped-table">
             <thead class="table-sticky-headers">
                 <th class="active" data-sort="alphabetic" data-sort-prop="full_name">{{t "Name" }}</th>
                 <th data-sort="email">{{t "Email" }}</th>
diff --git a/web/templates/settings/user_topics_settings.hbs b/web/templates/settings/user_topics_settings.hbs
index 1144bfe5f4..efcad67e70 100644
--- a/web/templates/settings/user_topics_settings.hbs
+++ b/web/templates/settings/user_topics_settings.hbs
@@ -26,7 +26,7 @@
         <input id="user_topics_search" class="search filter_text_input" type="text" placeholder="{{t 'Filter topics' }}" aria-label="{{t 'Filter topics' }}"/>
     </div>
     <div class="progressive-table-wrapper" data-simplebar>
-        <table class="table table-condensed table-striped wrapped-table">
+        <table class="table table-striped wrapped-table">
             <thead class="table-sticky-headers">
                 <th data-sort="alphabetic" data-sort-prop="stream">{{t "Stream" }}</th>
                 <th data-sort="alphabetic" data-sort-prop="topic">{{t "Topic" }}</th>