From 131127aa30f28a8f27f2131300ee600278b59f43 Mon Sep 17 00:00:00 2001
From: evykassirer <evy@zulip.com>
Date: Wed, 6 Sep 2023 14:38:15 -0700
Subject: [PATCH] recent: Rename #recent_topics_table.

---
 templates/zerver/app/index.html      |  2 +-
 web/e2e-tests/message-basics.test.ts |  2 +-
 web/src/recent_view_ui.js            | 48 ++++++++++++++--------------
 web/styles/dark_theme.css            | 14 ++++----
 web/styles/recent_topics.css         |  2 +-
 web/styles/zulip.css                 |  2 +-
 6 files changed, 35 insertions(+), 35 deletions(-)

diff --git a/templates/zerver/app/index.html b/templates/zerver/app/index.html
index 29ebcde0f5..b6c72f4cc0 100644
--- a/templates/zerver/app/index.html
+++ b/templates/zerver/app/index.html
@@ -225,7 +225,7 @@
             <div class="column-middle-inner">
                 <div id="recent_topics_view">
                     <div class="recent_topics_container">
-                        <div id="recent_topics_table"></div>
+                        <div id="recent_view_table"></div>
                         <div id="recent_topics_bottom_whitespace">
                             <div class="bottom-messages-logo">
                                 <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 773.12 773.12">
diff --git a/web/e2e-tests/message-basics.test.ts b/web/e2e-tests/message-basics.test.ts
index f10dd7a616..16d73ebd6b 100644
--- a/web/e2e-tests/message-basics.test.ts
+++ b/web/e2e-tests/message-basics.test.ts
@@ -97,7 +97,7 @@ async function un_narrow_by_clicking_org_icon(page: Page): Promise<void> {
 }
 
 async function expect_recent_topics(page: Page): Promise<void> {
-    await page.waitForSelector("#recent_topics_table", {visible: true});
+    await page.waitForSelector("#recent_view_table", {visible: true});
     assert.strictEqual(await page.title(), "Recent conversations - Zulip Dev - Zulip");
 }
 
diff --git a/web/src/recent_view_ui.js b/web/src/recent_view_ui.js
index d8069fa486..f22028487a 100644
--- a/web/src/recent_view_ui.js
+++ b/web/src/recent_view_ui.js
@@ -139,7 +139,7 @@ function get_row_type(row) {
     // Return "private" or "stream"
     // We use CSS method for finding row type until topics_widget gets initialized.
     if (!topics_widget) {
-        const $topic_rows = $("#recent_topics_table table tbody tr");
+        const $topic_rows = $("#recent_view_table table tbody tr");
         const $topic_row = $topic_rows.eq(row);
         const is_private = $topic_row.attr("data-private");
         if (is_private) {
@@ -163,7 +163,7 @@ function get_max_selectable_cols(row) {
 }
 
 function set_table_focus(row, col, using_keyboard) {
-    const $topic_rows = $("#recent_topics_table table tbody tr");
+    const $topic_rows = $("#recent_view_table table tbody tr");
     if ($topic_rows.length === 0 || row < 0 || row >= $topic_rows.length) {
         row_focus = 0;
         // return focus back to filters if we cannot focus on the table.
@@ -192,7 +192,7 @@ function set_table_focus(row, col, using_keyboard) {
 
     if (using_keyboard) {
         const scroll_element = document.querySelector(
-            "#recent_topics_table .table_fix_head .simplebar-content-wrapper",
+            "#recent_view_table .table_fix_head .simplebar-content-wrapper",
         );
         const half_height_of_visible_area = scroll_element.offsetHeight / 2;
         const topic_offset = topic_offset_to_visible_area($topic_row);
@@ -226,7 +226,7 @@ function set_table_focus(row, col, using_keyboard) {
 
 export function get_focused_row_message() {
     if (is_table_focused()) {
-        const $topic_rows = $("#recent_topics_table table tbody tr");
+        const $topic_rows = $("#recent_view_table table tbody tr");
         if ($topic_rows.length === 0) {
             return undefined;
         }
@@ -297,7 +297,7 @@ export function hide_loading_indicator() {
         abs_positioned: false,
     });
     // Show empty table text if there are no messages fetched.
-    $("#recent_topics_table tbody").addClass("required-text");
+    $("#recent_view_table tbody").addClass("required-text");
 }
 
 export function process_messages(messages) {
@@ -767,7 +767,7 @@ function topic_offset_to_visible_area(topic_row) {
         // topic and the callers will take care of undefined being returned.
         return undefined;
     }
-    const $scroll_container = $("#recent_topics_table .table_fix_head");
+    const $scroll_container = $("#recent_view_table .table_fix_head");
     const thead_height = 30;
     const under_closed_compose_region_height = 50;
 
@@ -791,8 +791,8 @@ function topic_offset_to_visible_area(topic_row) {
 }
 
 function recenter_focus_if_off_screen() {
-    const table_wrapper_element = document.querySelector("#recent_topics_table .table_fix_head");
-    const $topic_rows = $("#recent_topics_table table tbody tr");
+    const table_wrapper_element = document.querySelector("#recent_view_table .table_fix_head");
+    const $topic_rows = $("#recent_view_table table tbody tr");
 
     if (row_focus >= $topic_rows.length) {
         // User used a filter which reduced
@@ -852,7 +852,7 @@ export function complete_rerender() {
         search_val: $("#recent_topics_search").val() || "",
         is_spectator: page_params.is_spectator,
     });
-    $("#recent_topics_table").html(rendered_body);
+    $("#recent_view_table").html(rendered_body);
 
     // `show_selected_filters` needs to be called after the Recent
     // Conversations view has been added to the DOM, to ensure that filters
@@ -860,12 +860,12 @@ export function complete_rerender() {
     // was not the first view loaded in the app.
     show_selected_filters();
 
-    const $container = $("#recent_topics_table table tbody");
+    const $container = $("#recent_view_table table tbody");
     $container.empty();
     topics_widget = ListWidget.create($container, mapped_topic_values, {
-        name: "recent_topics_table",
+        name: "recent_view_table",
         get_item: ListWidget.default_get_item,
-        $parent_container: $("#recent_topics_table"),
+        $parent_container: $("#recent_view_table"),
         modifier(item) {
             return render_recent_view_row(format_conversation(item));
         },
@@ -882,7 +882,7 @@ export function complete_rerender() {
             ...ListWidget.generic_sort_functions("numeric", ["last_msg_id"]),
         },
         html_selector: get_topic_row,
-        $simplebar_container: $("#recent_topics_table .table_fix_head"),
+        $simplebar_container: $("#recent_view_table .table_fix_head"),
         callback_after_render: () => setTimeout(revive_current_focus, 0),
         is_scroll_position_for_render,
         post_scroll__pre_render_callback() {
@@ -1031,8 +1031,8 @@ function down_arrow_navigation() {
 }
 
 function get_page_up_down_delta() {
-    const table_height = $("#recent_topics_table .table_fix_head").height();
-    const table_header_height = $("#recent_topics_table table thead").height();
+    const table_height = $("#recent_view_table .table_fix_head").height();
+    const table_header_height = $("#recent_view_table table thead").height();
     const compose_box_height = $("#compose").height();
     // One usually wants PageDown to move what had been the bottom row
     // to now be at the top, so one can be confident one will see
@@ -1051,7 +1051,7 @@ function get_page_up_down_delta() {
 
 function page_up_navigation() {
     const $scroll_container = scroll_util.get_scroll_element(
-        $("#recent_topics_table .table_fix_head"),
+        $("#recent_view_table .table_fix_head"),
     );
     const delta = get_page_up_down_delta();
     const new_scrollTop = $scroll_container.scrollTop() - delta;
@@ -1064,11 +1064,11 @@ function page_up_navigation() {
 
 function page_down_navigation() {
     const $scroll_container = scroll_util.get_scroll_element(
-        $("#recent_topics_table .table_fix_head"),
+        $("#recent_view_table .table_fix_head"),
     );
     const delta = get_page_up_down_delta();
     const new_scrollTop = $scroll_container.scrollTop() + delta;
-    const table_height = $("#recent_topics_table .table_fix_head").height();
+    const table_height = $("#recent_view_table .table_fix_head").height();
     if (new_scrollTop >= table_height) {
         row_focus = topics_widget.get_current_list().length - 1;
     }
@@ -1278,7 +1278,7 @@ export function initialize() {
         filters = new Set(ls.get(ls_key));
     }
 
-    $("body").on("click", "#recent_topics_table .participant_profile", function (e) {
+    $("body").on("click", "#recent_view_table .participant_profile", function (e) {
         const participant_user_id = Number.parseInt($(this).attr("data-user-id"), 10);
         e.stopPropagation();
         const user = people.get_by_user_id(participant_user_id);
@@ -1292,7 +1292,7 @@ export function initialize() {
     );
 
     // Mute topic in a unmuted stream
-    $("body").on("click", "#recent_topics_table .stream_unmuted.on_hover_topic_mute", (e) => {
+    $("body").on("click", "#recent_view_table .stream_unmuted.on_hover_topic_mute", (e) => {
         e.stopPropagation();
         const $elt = $(e.target);
         const topic_row_index = $elt.closest("tr").index();
@@ -1304,7 +1304,7 @@ export function initialize() {
     });
 
     // Unmute topic in a unmuted stream
-    $("body").on("click", "#recent_topics_table .stream_unmuted.on_hover_topic_unmute", (e) => {
+    $("body").on("click", "#recent_view_table .stream_unmuted.on_hover_topic_unmute", (e) => {
         e.stopPropagation();
         const $elt = $(e.target);
         const topic_row_index = $elt.closest("tr").index();
@@ -1316,7 +1316,7 @@ export function initialize() {
     });
 
     // Unmute topic in a muted stream
-    $("body").on("click", "#recent_topics_table .stream_muted.on_hover_topic_unmute", (e) => {
+    $("body").on("click", "#recent_view_table .stream_muted.on_hover_topic_unmute", (e) => {
         e.stopPropagation();
         const $elt = $(e.target);
         const topic_row_index = $elt.closest("tr").index();
@@ -1328,7 +1328,7 @@ export function initialize() {
     });
 
     // Mute topic in a muted stream
-    $("body").on("click", "#recent_topics_table .stream_muted.on_hover_topic_mute", (e) => {
+    $("body").on("click", "#recent_view_table .stream_muted.on_hover_topic_mute", (e) => {
         e.stopPropagation();
         const $elt = $(e.target);
         const topic_row_index = $elt.closest("tr").index();
@@ -1344,7 +1344,7 @@ export function initialize() {
         change_focused_element($(e.target), "click");
     });
 
-    $("body").on("click", "#recent_topics_table .on_hover_topic_read", (e) => {
+    $("body").on("click", "#recent_view_table .on_hover_topic_read", (e) => {
         e.stopPropagation();
         const $elt = $(e.currentTarget);
         const topic_row_index = $elt.closest("tr").index();
diff --git a/web/styles/dark_theme.css b/web/styles/dark_theme.css
index e950e35903..4e4857ad62 100644
--- a/web/styles/dark_theme.css
+++ b/web/styles/dark_theme.css
@@ -817,7 +817,7 @@
         background-color: hsl(211deg 18% 25%) !important;
     }
 
-    .recent_topics_container #recent_topics_table .btn-recent-filters {
+    .recent_topics_container #recent_view_table .btn-recent-filters {
         background-color: hsl(211deg 29% 14%);
         border-color: hsl(0deg 0% 0%);
         color: hsl(0deg 0% 100%);
@@ -838,7 +838,7 @@
         }
     }
 
-    #recent_topics_table tr {
+    #recent_view_table tr {
         background-color: var(--color-background);
 
         &:hover {
@@ -846,7 +846,7 @@
         }
     }
 
-    #recent_topics_table .unread_topic {
+    #recent_view_table .unread_topic {
         background-color: hsl(212deg 30% 22% / 40%);
 
         &:hover {
@@ -855,7 +855,7 @@
     }
 
     .btn-recent-selected,
-    #recent_topics_table thead th {
+    #recent_view_table thead th {
         background-color: hsl(228deg 11% 17%) !important;
 
         &[data-sort]:hover {
@@ -863,7 +863,7 @@
         }
     }
 
-    #recent_topics_table td a {
+    #recent_view_table td a {
         color: hsl(206deg 89% 74%);
         text-decoration: none;
 
@@ -872,7 +872,7 @@
         }
     }
 
-    #recent_topics_table {
+    #recent_view_table {
         border-color: hsl(0deg 0% 0% / 60%);
 
         .fa-envelope,
@@ -928,7 +928,7 @@
     table,
     table th,
     table td,
-    #recent_topics_table table td {
+    #recent_view_table table td {
         border-color: hsl(0deg 0% 0% / 20%);
     }
 
diff --git a/web/styles/recent_topics.css b/web/styles/recent_topics.css
index 0b370433d4..422315f73c 100644
--- a/web/styles/recent_topics.css
+++ b/web/styles/recent_topics.css
@@ -6,7 +6,7 @@
     flex-direction: column;
     max-height: 100vh;
 
-    #recent_topics_table {
+    #recent_view_table {
         max-width: 100%;
         overflow: hidden !important;
         display: flex;
diff --git a/web/styles/zulip.css b/web/styles/zulip.css
index 7c5b65c950..8455187529 100644
--- a/web/styles/zulip.css
+++ b/web/styles/zulip.css
@@ -616,7 +616,7 @@ p.n-margin {
     }
 }
 
-.recent_topics_container #recent_topics_table {
+.recent_topics_container #recent_view_table {
     margin-top: var(--navbar-fixed-height);
 }