Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

tools/webpack: Run webpack in the foreground. 

`tools/run-dev.py` already backgrounds `tools/webpack` (and deals with
cleaning it up on exit), so there’s no need for `tools/webpack` to
also background the actual `webpack` process.  But when running
`tools/webpack` by itself, it’s annoying to clean up the backgrounded
process manually.

Run `webpack` in the foreground, using `os.execvp` so we don’t waste
memory on an intermediate wrapper process.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
This commit is contained in:
Anders Kaseorg 2019-04-22 13:59:11 -07:00 committed by Tim Abbott
parent ff342050ca
commit 12e2e0d658
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tools/webpack
View File

@ -2,10 +2,12 @@
import argparse import argparse
import os import os
import subprocess
import sys import sys
import json import json
if False:
from typing import NoReturn
# check for the venv # check for the venv
from lib import sanity_check from lib import sanity_check
sanity_check.check_venv(__file__) sanity_check.check_venv(__file__)
@ -19,7 +21,7 @@ STATIC_PATH = 'static/'
def build_for_prod_or_casper(quiet): def build_for_prod_or_casper(quiet):
# type: (bool) -> None # type: (bool) -> NoReturn
"""Builds for production, writing the output to disk""" """Builds for production, writing the output to disk"""
webpack_args = ['node', 'node_modules/.bin/webpack-cli', webpack_args = ['node', 'node_modules/.bin/webpack-cli',
@ -28,10 +30,10 @@ def build_for_prod_or_casper(quiet):
if quiet: if quiet:
webpack_args += ['--display', 'errors-only'] webpack_args += ['--display', 'errors-only']
print('Starting webpack compilation') print('Starting webpack compilation')
subprocess.check_call(webpack_args) os.execvp(webpack_args[0], webpack_args)
def build_for_dev_server(host, port, minify, disable_host_check): def build_for_dev_server(host, port, minify, disable_host_check):
# type: (str, str, bool, bool) -> None # type: (str, str, bool, bool) -> NoReturn
"""watches and rebuilds on changes, serving files from memory via webpack-dev-server""" """watches and rebuilds on changes, serving files from memory via webpack-dev-server"""
# This is our most dynamic configuration, which we use for our # This is our most dynamic configuration, which we use for our
@ -53,7 +55,7 @@ def build_for_dev_server(host, port, minify, disable_host_check):
webpack_args.append('--optimize-minimize') webpack_args.append('--optimize-minimize')
if disable_host_check: if disable_host_check:
webpack_args.append('--disable-host-check') webpack_args.append('--disable-host-check')
subprocess.Popen(webpack_args) os.execvp(webpack_args[0], webpack_args)
def build_for_most_tests(): def build_for_most_tests():
# type: () -> None # type: () -> None