Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

puppeteer: Remove flaky default streams test. 

This test has been flaking for a couple months, and it hasn't felt
worth it for anyone to debug, so we should disable or delete it.

I chose deletion, since I don't think this settings panel is a
high-value place for end-to-end testing.
This commit is contained in:
Tim Abbott 2023-09-21 16:57:04 -07:00
parent be4d4085f2
commit 12dd6c44a2
1 changed files with 0 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
web/e2e-tests/admin.test.ts
View File

@ -193,53 +193,6 @@ async function test_custom_realm_emoji(page: Page): Promise<void> {
await test_delete_emoji(page);
}
async function test_add_default_stream(page: Page): Promise<void> {
const streams = ["Denmark", "Venice"];
for (let i = 0; i < 2; i += 1) {
await page.click(`#select_default_stream_${i}_widget`);
await page.waitForSelector(".dropdown-list-container .list-item", {
visible: true,
});
const stream_to_select = `.dropdown-list-container .list-item[data-name="${streams[i]}"]`;
await page.waitForSelector(stream_to_select, {visible: true});
await page.click(stream_to_select);
assert((await page.$(".dropdown-list-container")) === null);
}
await page.click("#add-default-stream-modal .dialog_submit_button");
await common.wait_for_micromodal_to_close(page);
let stream_id = await common.get_stream_id(page, "Denmark");
let row = `.default_stream_row[data-stream-id='${CSS.escape(stream_id.toString())}']`;
await page.waitForSelector(row, {visible: true});
stream_id = await common.get_stream_id(page, "Venice");
row = `.default_stream_row[data-stream-id='${CSS.escape(stream_id.toString())}']`;
await page.waitForSelector(row, {visible: true});
}
async function test_remove_default_stream(page: Page, row: string): Promise<void> {
await page.click(row + " button.remove-default-stream");
// assert row doesn't exist.
await page.waitForSelector(row, {hidden: true});
}
async function test_default_streams(page: Page): Promise<void> {
await page.click("li[data-section='default-streams-list']");
await page.click("#show-add-default-streams-modal");
await common.wait_for_micromodal_to_open(page);
const stream_name = "Denmark";
const stream_id = await common.get_stream_id(page, stream_name);
const row = `.default_stream_row[data-stream-id='${CSS.escape(stream_id.toString())}']`;
await test_add_default_stream(page);
await test_remove_default_stream(page, row);
}
async function test_upload_realm_icon_image(page: Page): Promise<void> {
const upload_handle = await page.$("#realm-icon-upload-widget .image_file_input");
assert.ok(upload_handle);
@ -324,7 +277,6 @@ async function admin_test(page: Page): Promise<void> {
await test_custom_realm_emoji(page);
await test_organization_profile(page);
}
await test_default_streams(page);
await test_authentication_methods(page);
}