Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

stream settings: Fix subscriber counts when creating invite-only streams. 

Previously, when creating an invite-only stream, the subscriber counts
were not being rendered properly, in that the "create" event for the
stream had the user not yet subscribed (so can_add_subscribers was
false), and then the rerendering we did when the user susbcribed just
tried to update the number, not actually rerender the thing.
This commit is contained in:
Tim Abbott 2018-03-10 09:45:31 -08:00
parent ddef39832f
commit 12db219305
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
static/js/subs.js
View File

@ -149,10 +149,10 @@ exports.set_color = function (stream_id, color) {
stream_edit.set_stream_property(sub, 'color', color);
};
exports.rerender_subscribers_count = function (sub) {
exports.rerender_subscribers_count = function (sub, just_subscribed) {
var stream_row = row_for_stream_id(sub.stream_id);
stream_data.update_subscribers_count(sub);
if (!sub.can_add_subscribers) {
if (!sub.can_add_subscribers || (just_subscribed && sub.invite_only)) {
var sub_count = templates.render("subscription_count", sub);
stream_row.find('.subscriber-count').expectOne().html(sub_count);
} else {
@ -215,7 +215,7 @@ exports.update_settings_for_subscribed = function (sub) {
var settings_button = settings_button_for_sub(sub).removeClass("unsubscribed");
if (button.length !== 0) {
exports.rerender_subscribers_count(sub);
exports.rerender_subscribers_count(sub, true);
button.toggleClass("checked");
settings_button.text(i18n.t("Unsubscribe"));