Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Actually fix main Tornado memory leak of handler objects. 

This line appears to have been lost in rebasing from the original
implementation of 1396eb7022faec4c2d91553800a35781a96dd5bd; so the
previous fix actually only addressed the issue in a rare exception
case.
This commit is contained in:
Tim Abbott 2016-03-20 16:12:37 -07:00
parent 7aab17d0c0
commit 12a5a3a6e1
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
zerver/lib/event_queue.py
View File

@ -163,6 +163,7 @@ class ClientDescriptor(object):
def disconnect_handler(self, client_closed=False): def disconnect_handler(self, client_closed=False):
if self.current_handler_id: if self.current_handler_id:
clear_descriptor_by_handler_id(self.current_handler_id, None) clear_descriptor_by_handler_id(self.current_handler_id, None)
clear_handler_by_id(self.current_handler_id)
if client_closed: if client_closed:
logging.info("Client disconnected for queue %s (%s via %s)" % logging.info("Client disconnected for queue %s (%s via %s)" %
(self.event_queue.id, self.user_profile_email, (self.event_queue.id, self.user_profile_email,