Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

inbox_ui: Fix unable to insert new stream. 

There were 2 issues:
* Wrong format for creating new Map object used.
* Use of `topic_dict` instead of `topics_dict`, which resulted
in `stream_key` being present in `topics_dict` even after stream
has been marked as read. This made inbox believe that the
stream was already rendered even though it was not.
This commit is contained in:
Aman Agrawal 2023-10-06 17:12:58 +00:00 committed by Tim Abbott
parent 9dc1e8ed17
commit 115de0e847
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
web/src/inbox_ui.js
View File

@ -321,7 +321,7 @@ function insert_stream(stream_id, topic_dict) {
const sorted_stream_keys = get_sorted_stream_keys(); const sorted_stream_keys = get_sorted_stream_keys();
const stream_index = sorted_stream_keys.indexOf(stream_key); const stream_index = sorted_stream_keys.indexOf(stream_key);
const rendered_stream = render_inbox_stream_container({ const rendered_stream = render_inbox_stream_container({
topics_dict: new Map(stream_key, topics_dict.get(stream_key)), topics_dict: new Map([[stream_key, topics_dict.get(stream_key)]]),
streams_dict, streams_dict,
}); });
@ -911,7 +911,7 @@ export function update() {
topics_dict.set(stream_key, get_sorted_row_dict(topics_dict.get(stream_key))); topics_dict.set(stream_key, get_sorted_row_dict(topics_dict.get(stream_key)));
insert_topics(topic_keys_to_insert, stream_key); insert_topics(topic_keys_to_insert, stream_key);
} else { } else {
topic_dict.delete(stream_key); topics_dict.delete(stream_key);
streams_dict.delete(stream_key); streams_dict.delete(stream_key);
get_stream_container(stream_key).remove(); get_stream_container(stream_key).remove();
} }