Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

settings: Wait for settings overlay to close. 

Since pressing `escape` key closes flatpickr and settings overlay
at the same time, we need to wait for the settings to be not
visible.

If we don't wait for the settings overlay to close, the next test
could think the settings overlay is already open and continue with
its tests which can easily become flaky.
This commit is contained in:
Aman Agrawal 2024-11-21 19:45:34 +05:30
parent d4aebccd62
commit 11153eb2c8
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
web/e2e-tests/settings.test.ts
View File

@ -42,6 +42,7 @@ async function close_settings_and_date_picker(page: Page): Promise<void> {
await page.keyboard.press("Escape"); await page.keyboard.press("Escape");
await page.waitForSelector(".flatpickr-calendar", {hidden: true}); await page.waitForSelector(".flatpickr-calendar", {hidden: true});
await page.waitForSelector("#settings_overlay_container", {hidden: true});
} }
async function test_change_full_name(page: Page): Promise<void> { async function test_change_full_name(page: Page): Promise<void> {