Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Rearrange calls to then() in frontend test suite. 

Apparently after you call waitForText, if you don't specify
a callback function, you need to put the next stuff after
a casper.then() -- not doing so caused some tests to fail
if, e.g. the subscription list did not load super-promptly
(because we checked for the text even before the waitFor
expired; in other words, we were not blocking on it.)

(imported from commit c71d543db0aba0c27b5136b92bb6e28e63278ac5)
This commit is contained in:
Waseem Daher 2013-01-08 15:35:33 -05:00
parent 055652e16d
commit 105f0aa25a
1 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
zephyr/tests/frontend/tests.js
View File

@ -286,34 +286,28 @@ casper.then(function() {
casper.test.assertUrlMatch(/^http:\/\/[^\/]+\/#subscriptions/, 'URL suggests we are on subscriptions page');
casper.test.assertExists('#subscriptions.tab-pane.active', 'Subscriptions page is active');
casper.waitForText('Denmark'); // subscriptions need to load
casper.test.assertTextExists('Denmark', 'Initial subscriptions loaded');
});
casper.then(function() {
casper.test.assertTextExists('Denmark', 'Initial subscriptions loaded');
casper.fill('form#add_new_subscription', {streams: 'Waseemio'});
casper.click('form#add_new_subscription input.btn.btn-primary');
casper.waitForText('Waseemio');
});
casper.then(function() {
casper.waitForText('Waseemio');
// TODO: Make this more robust.
// I tried to do it with assertSelectorHasText, but it wasn't quite working.
casper.test.assertTextExists('Successfully added subscription to Waseemio', 'Subscribing to a stream');
});
casper.then(function() {
casper.fill('form#add_new_subscription', {streams: 'WASeemio'});
casper.click('form#add_new_subscription input.btn.btn-primary');
});
casper.then(function() {
casper.waitForText('Already subscribed');
casper.test.assertTextExists('Already subscribed', "Can't subscribe twice to a stream");
});
casper.then(function() {
casper.test.assertTextExists('Already subscribed', "Can't subscribe twice to a stream");
casper.fill('form#add_new_subscription', {streams: ' '});
casper.click('form#add_new_subscription input.btn.btn-primary');
casper.waitForText('Error adding subscription');
});
casper.then(function() {
casper.waitForText('Error adding subscription');
casper.test.assertTextExists('Error adding subscription', "Can't subscribe to an empty stream name");
});