Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Revert "click_handlers: Don't treat dropdown menuitem clicks the same as links." 

This reverts commit 202c04988f.

See https://github.com/zulip/zulip/pull/24133#issuecomment-1416921919.
This commit is contained in:
Tim Abbott 2023-02-05 10:03:33 -08:00
parent 9881760796
commit 0f155b597f
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
static/js/click_handlers.js
View File

@ -983,13 +983,8 @@ export function initialize() {
} }
if (compose_state.composing()) { if (compose_state.composing()) {
const $closest_links = $(e.target).closest("a");
const nearby_link_exists = $closest_links.length > 0;
// Links that are actually dropdown widget don't count.
const inside_dropdown_widget =
nearby_link_exists && $closest_links[0].role === "menuitem";
if ( if (
(nearby_link_exists && !inside_dropdown_widget) || $(e.target).closest("a").length > 0 ||
$(e.target).closest(".copy_codeblock").length > 0 $(e.target).closest(".copy_codeblock").length > 0
) { ) {
// Refocus compose message text box if one clicks an external // Refocus compose message text box if one clicks an external