ts: Migrate debug.js to TypeScript.

TypeScript doesn't understand Array.prototype.slice.call; rather than dealing with the
type-checking issues around it, we remove it; it was only necessary for ancient browsers where
NodeList isn’t directly iterable.

tools/test-js-with-node

@@ -75,7 +75,7 @@ EXEMPT_FILES = make_set(
         "web/src/csrf.ts",
         "web/src/css_variables.ts",
         "web/src/dark_theme.js",
-        "web/src/debug.js",
+        "web/src/debug.ts",
         "web/src/deprecated_feature_notice.js",
         "web/src/desktop_integration.js",
         "web/src/dialog_widget.js",

web/src/debug.ts

@@ -10,20 +10,26 @@
     evaluates to foo() and prints the elapsed time
     to the console along with the name "foo". */
 
-export function print_elapsed_time(name, fun) {
+type Collision = {
+    id: string;
+    count: number;
+    node: string;
+};
+
+export function print_elapsed_time<T>(name: string, fun: () => T): T {
     const t0 = Date.now();
     const out = fun();
     const t1 = Date.now();
-    console.log(name + ": " + (t1 - t0) + " ms");
+    console.log(`${name} : ${t1 - t0} ms`);
     return out;
 }
 
-export function check_duplicate_ids() {
+export function check_duplicate_ids(): {collisions: Collision[]; total_collisions: number} {
-    const ids = new Set();
+    const ids = new Set<string>();
-    const collisions = [];
+    const collisions: Collision[] = [];
     let total_collisions = 0;
 
-    for (const o of Array.prototype.slice.call(document.querySelectorAll("*"))) {
+    for (const o of document.querySelectorAll("*")) {
         if (o.id && ids.has(o.id)) {
             const el = collisions.find((c) => c.id === o.id);
 
@@ -35,17 +41,7 @@ export function check_duplicate_ids() {
                 collisions.push({
                     id: o.id,
                     count: 1,
-                    node:
+                    node: `<${tag} class="${o.className}" id="${o.id}"></${tag}>`,
-                        "<" +
-                        tag +
-                        " className='" +
-                        o.className +
-                        "' id='" +
-                        o.id +
-                        "'>" +
-                        "</" +
-                        tag +
-                        ">",
                 });
             } else {
                 el.count += 1;
@@ -92,14 +88,14 @@ export function check_duplicate_ids() {
  * after section b.
  */
 export class IterationProfiler {
-    sections = new Map();
+    sections = new Map<string, number>();
     last_time = window.performance.now();
 
-    iteration_start() {
+    iteration_start(): void {
         this.section("_iteration_overhead");
     }
 
-    iteration_stop() {
+    iteration_stop(): void {
         const now = window.performance.now();
         const diff = now - this.last_time;
         if (diff > 1) {
@@ -111,13 +107,13 @@ export class IterationProfiler {
         this.last_time = now;
     }
 
-    section(label) {
+    section(label: string): void {
         const now = window.performance.now();
         this.sections.set(label, (this.sections.get(label) || 0) + (now - this.last_time));
         this.last_time = now;
     }
 
-    done() {
+    done(): void {
         this.section("_iteration_overhead");
 
         for (const [prop, cost] of this.sections) {