third: Rename thirdparty-fonts.css for better clarity.

Now it's clear that this is just legacy fontawesome styles.

docs/subsystems/html_css.md

@@ -17,7 +17,6 @@ The CSS files are:
 * `pygments.css` - CSS for Python syntax highlighting
 * `activity.css` - CSS for the `activity` app
 * `fonts.css` - Fonts for text in the Zulip app
-* `static/third/thirdparty-fonts.css` - Font Awesome (used for icons)
 
 The CSS for the Zulip web application UI is primarily here:
 

docs/subsystems/user-docs.md

@@ -192,13 +192,12 @@ a new line to be formatted this way.
 
 ### Icons
 
-You can refer to features in the Zulip UI by referencing their names and
-their [FontAwesome](http://fontawesome.io) (version 4.7.0) text icons within
-parentheses. The source for the text icons is located in
-`static/third/thirdparty-fonts.css`. **Note:** It is strongly recommended to use
-the new base class `fa` instead of the older base class `icon-vector` when
-specifying icons. In future we will be removing support for the icons with base
-class `icon-vector`.
+You can refer to features in the Zulip UI by referencing their names
+and their [FontAwesome](http://fontawesome.io) (version 4.7.0) text
+icons within parentheses. **Note:** We are migrating to the modern
+font awesome base class `fa` instead of the older base class
+`icon-vector` when specifying icons. In future we will be removing
+support for the icons with base class `icon-vector`.
 
 * cog (<i class="fa fa-cog"></i>) icon — `cog (<i
 class="fa fa-cog"></i>) icon`

static/styles/portico-styles.scss

@@ -4,6 +4,6 @@
 @import "portico-signin";
 @import "pygments";
 @import "../node_modules/font-awesome/css/font-awesome.css";
-@import "../third/thirdparty-fonts.css";
+@import "../third/fontawesome-legacy.css";
 @import "../generated/icons/style.css";
 @import "../node_modules/source-sans-pro/source-sans-pro.css";

static/third/fontawesome-legacy.css

@@ -1,3 +1,4 @@
+/* Legacy fontawesome names; we should migrate to the fa- style */
 
 /* Our custom narrowing symbol */
 .icon-vector-narrow:before               { content: "\f054"; }

tools/linter_lib/custom_check.py

@@ -562,7 +562,7 @@ def build_custom_checkers(by_lang):
          'bad_lines': ['background: url(https://example.com/image.png);']},
         {'pattern': '^[ ][ ][a-zA-Z0-9]',
          'description': "Incorrect 2-space indentation in CSS",
-         'exclude': set(['static/third/thirdparty-fonts.css']),
+         'exclude': set(['static/third/fontawesome-legacy.css']),
          'strip': '\n',
          'good_lines': ["    color: white;", "color: white;"],
          'bad_lines': ["  color: white;"]},

tools/webpack.assets.json

@@ -54,7 +54,7 @@
         "./static/third/bootstrap-notify/css/bootstrap-notify.css",
         "./static/third/spectrum/spectrum.css",
         "./node_modules/font-awesome/css/font-awesome.css",
-        "./static/third/thirdparty-fonts.css",
+        "./static/third/fontawesome-legacy.css",
         "./static/generated/icons/style.css",
         "./static/node_modules/katex/dist/katex.css",
         "./node_modules/source-sans-pro/source-sans-pro.css",