Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

lint: Enforce semicolon spacing in eslint. 

We only had a few exceptions to this rule; the zjquery one was actually a bug.
This commit is contained in:
Tim Abbott 2019-01-05 15:29:31 -08:00
parent 99721755e8
commit 0c6175f27e
3 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.eslintrc.json
View File

@ -384,6 +384,7 @@
"quotes": [ 0, "single" ], "quotes": [ 0, "single" ],
"radix": 2, "radix": 2,
"semi": 2, "semi": 2,
"semi-spacing": [2, {"before": false, "after": true}],
"space-before-blocks": 2, "space-before-blocks": 2,
"space-before-function-paren": [ "error", "space-before-function-paren": [ "error",
{ {

2
frontend_tests/zjsunit/zjquery.js
View File

@ -210,7 +210,7 @@ exports.make_new_elem = function (selector, opts) {
}, },
focusout: function () { focusout: function () {
focused = false; focused = false;
return ; return self;
}, },
get: function (idx) { get: function (idx) {
// We have some legacy code that does $('foo').get(0). // We have some legacy code that does $('foo').get(0).

3
static/js/message_edit.js
View File

@ -392,7 +392,8 @@ function edit_message(row, raw_content) {
// Scroll to keep the message content in the same place // Scroll to keep the message content in the same place
var edit_top = message_edit_content[0].getBoundingClientRect().top; var edit_top = message_edit_content[0].getBoundingClientRect().top;
var scroll_by = edit_top - content_top + 5 /* border and padding */; /* adjust for border and padding */
var scroll_by = edit_top - content_top + 5;
edit_obj.scrolled_by = scroll_by; edit_obj.scrolled_by = scroll_by;
message_viewport.scrollTop(message_viewport.scrollTop() + scroll_by); message_viewport.scrollTop(message_viewport.scrollTop() + scroll_by);