Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

code-style: Simplify discussion of third-party code.

This commit is contained in:
Tim Abbott 2017-10-06 13:27:59 -07:00
parent a632c8471d
commit 0ac78cb14d
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
docs/code-style.md
View File

@ -205,10 +205,7 @@ with the exception of `_.any`, which we prefer over the less clear
## More arbitrary style things ## More arbitrary style things
### General ### Line length
Keep third-party static files under the directory
`static/third/`, with one subdirectory per third-party project.
We have an absolute hard limit on line length only for some files, but We have an absolute hard limit on line length only for some files, but
we should still avoid extremely long lines. A general guideline is: we should still avoid extremely long lines. A general guideline is:
@ -295,6 +292,5 @@ All significant new features should come with tests. See testing.
### Third party code ### Third party code
When adding new third-party packages to our codebase, please include See [our docs on dependencies](dependencies.html) for discussion of
"[third]" at the beginning of the commit message. You don't necessarily rules about integrating third-party projects.
need to do this when patching third-party code that's already in tree.