Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

notifications: Extract notification title retrieval. 

This commit aims to extract all logic related to obtaining
notification title from the `process_notification` function into
a separate `get_notification_title` function.
This commit is contained in:
Daniil Fadeev 2023-07-27 12:09:17 +03:00 committed by Tim Abbott
parent fe5d680f27
commit 0a11a4b983
1 changed files with 23 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
web/src/notifications.js
View File

@ -264,22 +264,12 @@ function remove_sender_from_list_of_recipients(message) {
.slice(", ".length, -", ".length);
}
export function process_notification(notification) {
const message = notification.message;
const content = get_notification_content(message);
const key = get_notification_key(message);
let notification_object;
let other_recipients;
function get_notification_title(message, content, msg_count) {
let title = message.sender_full_name;
let msg_count = 1;
let other_recipients;
debug_notification_source_value(message);
if (notice_memory.has(key)) {
msg_count = notice_memory.get(key).msg_count + 1;
if (msg_count > 1) {
title = msg_count + " messages from " + title;
notification_object = notice_memory.get(key).obj;
notification_object.close();
}
switch (message.type) {
@ -309,6 +299,26 @@ export function process_notification(notification) {
}
}
return title;
}
export function process_notification(notification) {
const message = notification.message;
const content = get_notification_content(message);
const key = get_notification_key(message);
let notification_object;
let msg_count = 1;
debug_notification_source_value(message);
if (notice_memory.has(key)) {
msg_count = notice_memory.get(key).msg_count + 1;
notification_object = notice_memory.get(key).obj;
notification_object.close();
}
const title = get_notification_title(message, content, msg_count);
if (notification.desktop_notify) {
const icon_url = people.small_avatar_url(message);
notification_object = new NotificationAPI(title, {