From 09ff0c400d5dd8db40a0f285b418569f9a842c02 Mon Sep 17 00:00:00 2001 From: Steve Howell Date: Wed, 20 Jan 2021 18:39:32 +0000 Subject: [PATCH] tools: Rename tool to check-schemas. --- docs/subsystems/events-system.md | 2 +- frontend_tests/node_tests/lib/events.js | 2 +- tools/{check-node-fixtures => check-schemas} | 0 tools/ci/frontend | 4 ++-- tools/test-all | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) rename tools/{check-node-fixtures => check-schemas} (100%) diff --git a/docs/subsystems/events-system.md b/docs/subsystems/events-system.md index e62f077489..d0a7928729 100644 --- a/docs/subsystems/events-system.md +++ b/docs/subsystems/events-system.md @@ -369,7 +369,7 @@ in `frontend_tests/node_tests/lib/events.js`, a test of the `server_events_dispatch.js` code for that event in `frontend_tests/node_tests/dispatch.js`, and verify your example against the two versions of the schema that you declared above using -`tools/check-node-fixtures`. +`tools/check-schemas`. #### Code coverage diff --git a/frontend_tests/node_tests/lib/events.js b/frontend_tests/node_tests/lib/events.js index 553c56dac8..80b771f8a3 100644 --- a/frontend_tests/node_tests/lib/events.js +++ b/frontend_tests/node_tests/lib/events.js @@ -2,7 +2,7 @@ // These events are not guaranteed to be perfectly // representative of what the server sends. We -// have a tool called check-node-fixtures that tries +// have a tool called check-schemas that tries // to validate this data against server side schemas, // but there are certain edge cases that the tool now // skips. And even when the data matches the schema, diff --git a/tools/check-node-fixtures b/tools/check-schemas similarity index 100% rename from tools/check-node-fixtures rename to tools/check-schemas diff --git a/tools/ci/frontend b/tools/ci/frontend index 87ea614b5a..af91acffff 100755 --- a/tools/ci/frontend +++ b/tools/ci/frontend @@ -10,8 +10,8 @@ set -x # Run the node tests first, since they're fast and deterministic ./tools/test-js-with-node --coverage -# Check the node fixtures (also fast) -./tools/check-node-fixtures +# Check that various schemas are consistent. (is fast) +./tools/check-schemas # Check capitalization of strings ./manage.py makemessages --locale en diff --git a/tools/test-all b/tools/test-all index 561675d170..f4046ba2c3 100755 --- a/tools/test-all +++ b/tools/test-all @@ -71,7 +71,7 @@ run ./tools/test-api # ci/frontend run ./tools/lint --groups=frontend $FORCEARG run ./tools/test-js-with-node -run ./tools/check-node-fixtures +run ./tools/check-schemas run ./manage.py makemessages --locale en run env PYTHONWARNINGS=ignore ./tools/check-capitalization --no-generate run env PYTHONWARNINGS=ignore ./tools/check-frontend-i18n --no-generate