Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

populate_db: Limit user_profiles for private messages to zulip realm. 

These are used for creating huddles and private messages (and some
UserPresence objects). It'd be really weird, and potentially create some
Messages that break our assumptions, for this to end up involving users
in multiple realms.
I believe currently this hasn't been happening, because when
this line runs, there are only users in "zulip" realm and system bots in
"zulipinternal" - but the query has been excluding bots already.

Still, this query should be explicit about grabbing users from a single
realm. This will also be helpful for the work adding the denormalized
Message.realm field - so that the realm of Message objects that get
manually created in generate_and_send_messages can be simply set to
"zulip" with confidence that it's correct.
This commit is contained in:
Mateusz Mandera 2022-09-22 21:30:52 +02:00 committed by Tim Abbott
parent c6abb7bedf
commit 0799ec1a43
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
zilencer/management/commands/populate_db.py
View File

@ -764,7 +764,9 @@ class Command(BaseCommand):
] ]
# Extract a list of all users # Extract a list of all users
user_profiles: List[UserProfile] = list(UserProfile.objects.filter(is_bot=False)) user_profiles: List[UserProfile] = list(
UserProfile.objects.filter(is_bot=False, realm=zulip_realm)
)
# Create a test realm emoji. # Create a test realm emoji.
IMAGE_FILE_PATH = static_path("images/test-images/checkbox.png") IMAGE_FILE_PATH = static_path("images/test-images/checkbox.png")