Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

eslint: Enable sort-imports rule. 

I figure we should enable this before we have lots of imports.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
This commit is contained in:
Anders Kaseorg 2019-10-30 12:13:53 -07:00 committed by Anders Kaseorg
parent 0ae2c5c96e
commit 042c558bb3
4 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.eslintrc.json
View File

@ -390,6 +390,7 @@
"radix": "error", "radix": "error",
"semi": "error", "semi": "error",
"semi-spacing": ["error", {"before": false, "after": true}], "semi-spacing": ["error", {"before": false, "after": true}],
"sort-imports": "error",
"space-before-blocks": "error", "space-before-blocks": "error",
"space-before-function-paren": [ "error", "space-before-function-paren": [ "error",
{ {

2
static/js/portico/landing-page.js
View File

@ -3,8 +3,8 @@ const ELECTRON_APP_URL_LINUX = "https://github.com/zulip/zulip-desktop/releases/
const ELECTRON_APP_URL_MAC = "https://github.com/zulip/zulip-desktop/releases/download/v" + ELECTRON_APP_VERSION + "/Zulip-" + ELECTRON_APP_VERSION + ".dmg"; const ELECTRON_APP_URL_MAC = "https://github.com/zulip/zulip-desktop/releases/download/v" + ELECTRON_APP_VERSION + "/Zulip-" + ELECTRON_APP_VERSION + ".dmg";
const ELECTRON_APP_URL_WINDOWS = "https://github.com/zulip/zulip-desktop/releases/download/v" + ELECTRON_APP_VERSION + "/Zulip-Web-Setup-" + ELECTRON_APP_VERSION + ".exe"; const ELECTRON_APP_URL_WINDOWS = "https://github.com/zulip/zulip-desktop/releases/download/v" + ELECTRON_APP_VERSION + "/Zulip-Web-Setup-" + ELECTRON_APP_VERSION + ".exe";
import { detect_user_os } from './tabbed-instructions.js';
import render_tabs from './team.js'; import render_tabs from './team.js';
import {detect_user_os} from './tabbed-instructions.js';
export function path_parts() { export function path_parts() {
return window.location.pathname.split('/').filter(function (chunk) { return window.location.pathname.split('/').filter(function (chunk) {

2
tools/webpack-helpers.ts
View File

@ -1,5 +1,5 @@
import { basename, resolve } from 'path';
import { RuleSetRule, RuleSetUseItem } from 'webpack'; import { RuleSetRule, RuleSetUseItem } from 'webpack';
import { basename, resolve } from 'path';
export const cacheLoader: RuleSetUseItem = { export const cacheLoader: RuleSetUseItem = {
loader: 'cache-loader', loader: 'cache-loader',

14
tools/webpack.config.ts
View File

@ -1,15 +1,15 @@
import { basename, resolve } from 'path'; import { basename, resolve } from 'path';
import { cacheLoader, getExposeLoaders } from './webpack-helpers';
import BundleTracker from 'webpack4-bundle-tracker'; import BundleTracker from 'webpack4-bundle-tracker';
import webpack from 'webpack'; import CleanCss from 'clean-css';
import HtmlWebpackPlugin from 'html-webpack-plugin';
import MiniCssExtractPlugin from 'mini-css-extract-plugin';
import OptimizeCssAssetsPlugin from 'optimize-css-assets-webpack-plugin';
import TerserPlugin from 'terser-webpack-plugin';
// The devServer member of webpack.Configuration is managed by the // The devServer member of webpack.Configuration is managed by the
// webpack-dev-server package. We are only importing the type here. // webpack-dev-server package. We are only importing the type here.
import _webpackDevServer from 'webpack-dev-server'; import _webpackDevServer from 'webpack-dev-server';
import { getExposeLoaders, cacheLoader } from './webpack-helpers'; import webpack from 'webpack';
import MiniCssExtractPlugin from 'mini-css-extract-plugin';
import OptimizeCssAssetsPlugin from 'optimize-css-assets-webpack-plugin';
import CleanCss from 'clean-css';
import TerserPlugin from 'terser-webpack-plugin';
import HtmlWebpackPlugin from 'html-webpack-plugin';
const assets = require('./webpack.assets.json'); const assets = require('./webpack.assets.json');