From 036a90f3754bc73972e6906b77281d02e438b227 Mon Sep 17 00:00:00 2001 From: Zixuan James Li Date: Mon, 18 Jul 2022 15:55:30 -0400 Subject: [PATCH] settings: Add isinstance check before filtering. This is a follow-up to https://github.com/typeddjango/django-stubs/pull/1038. Signed-off-by: Zixuan James Li --- zproject/computed_settings.py | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/zproject/computed_settings.py b/zproject/computed_settings.py index 05aefc6f24..d4494f63c1 100644 --- a/zproject/computed_settings.py +++ b/zproject/computed_settings.py @@ -2,6 +2,7 @@ import os import sys import time from copy import deepcopy +from pathlib import Path from typing import Any, Dict, List, Tuple, Union from urllib.parse import urljoin @@ -159,9 +160,16 @@ ALLOWED_HOSTS += REALM_HOSTS.values() class TwoFactorLoader(app_directories.Loader): - def get_dirs(self) -> List[Union[bytes, str]]: + def get_dirs(self) -> List[Union[str, Path]]: dirs = super().get_dirs() - return [d for d in dirs if d.match("two_factor/*")] + # app_directories.Loader returns only a list of + # Path objects by calling get_app_template_dirs + two_factor_dirs: List[Union[str, Path]] = [] + for d in dirs: + assert isinstance(d, Path) + if d.match("two_factor/*"): + two_factor_dirs.append(d) + return two_factor_dirs MIDDLEWARE = (