Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

stream_popover: Fix confirm button not disabled bug. 

On updating the stream from the dropdown menu in the move-messages popover,
the confirm button is enabled. On changing the stream back to the initial
value, doesn't disable the confirm button. It can result in the
creation of infinite notifications.

On stream update, 'update_submit_button_disabled_state()' doesn't receive
'stream_id' as a parameter, resulting in 'undefined' stream_id,
'button.disabled' is always set to false after the first update.
This commit is contained in:
Prakhar Pratyush 2022-12-16 02:10:41 +05:30 committed by Tim Abbott
parent 8dc3e086c9
commit 01961b4282
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
static/js/stream_popover.js
View File

@ -534,7 +534,7 @@ export function build_move_topic_to_stream_popover(current_stream_id, topic_name
} }
function move_topic_on_update() { function move_topic_on_update() {
update_submit_button_disabled_state(); update_submit_button_disabled_state(stream_widget.value());
set_stream_topic_typeahead(); set_stream_topic_typeahead();
} }