Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

attachments_ui: Fix TypeScript noUncheckedIndexedAccess errors. 

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg 2024-05-30 10:07:58 -07:00
parent 9b711cda20
commit 01677db59e
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
web/src/attachments_ui.ts
View File

@ -167,12 +167,12 @@ function render_attachments_ui(): void {
scroll_util.reset_scrollbar($uploaded_files_table.closest(".progressive-table-wrapper")); scroll_util.reset_scrollbar($uploaded_files_table.closest(".progressive-table-wrapper"));
} }
function format_attachment_data(new_attachments: ServerAttachment[]): Attachment[] { function format_attachment_data(attachment: ServerAttachment): Attachment {
return new_attachments.map((attachment) => ({ return {
...attachment, ...attachment,
create_time_str: timerender.render_now(new Date(attachment.create_time)).time_str, create_time_str: timerender.render_now(new Date(attachment.create_time)).time_str,
size_str: bytes_to_size(attachment.size), size_str: bytes_to_size(attachment.size),
})); };
} }
export function update_attachments(event: AttachmentEvent): void { export function update_attachments(event: AttachmentEvent): void {
@ -184,7 +184,7 @@ export function update_attachments(event: AttachmentEvent): void {
attachments = attachments.filter((a) => a.id !== event.attachment.id); attachments = attachments.filter((a) => a.id !== event.attachment.id);
} }
if (event.op === "add" || event.op === "update") { if (event.op === "add" || event.op === "update") {
attachments.push(format_attachment_data([event.attachment])[0]); attachments.push(format_attachment_data(event.attachment));
} }
upload_space_used = event.upload_space_used; upload_space_used = event.upload_space_used;
// TODO: This is inefficient and we should be able to do some sort // TODO: This is inefficient and we should be able to do some sort
@ -213,7 +213,9 @@ export function set_up_attachments(): void {
success(data) { success(data) {
const clean_data = attachment_api_response_schema.parse(data); const clean_data = attachment_api_response_schema.parse(data);
loading.destroy_indicator($("#attachments_loading_indicator")); loading.destroy_indicator($("#attachments_loading_indicator"));
attachments = format_attachment_data(clean_data.attachments); attachments = clean_data.attachments.map((attachment) =>
format_attachment_data(attachment),
);
upload_space_used = clean_data.upload_space_used; upload_space_used = clean_data.upload_space_used;
render_attachments_ui(); render_attachments_ui();
}, },