Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/zerver/webhooks/beanstalk/tests.py

145 lines
8.4 KiB
Python
Raw Normal View History

Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
# -*- coding: utf-8 -*-
zerver/webhooks: Change use of typing.Text to str.
2018-05-10 19:34:01 +02:00
from typing import Dict
webhooks/beanstalk: Filter specific Git branches.
2017-04-22 02:34:53 +02:00
python: Sort imports in webhooks.
2017-11-16 00:43:10 +01:00
from mock import MagicMock, patch
tests: Split out ZulipTestCase and WebhookTestCase to a separate file. Fixes #1671.
2016-11-10 19:30:09 +01:00
from zerver.lib.test_classes import WebhookTestCase
python: Sort imports in webhooks.
2017-11-16 00:43:10 +01:00
from zerver.lib.webhooks.git import COMMITS_LIMIT
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
python: Sort webhooks imports with isort.
2020-01-14 22:06:24 +01:00
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
class BeanstalkHookTests(WebhookTestCase):
STREAM_NAME = 'commits'
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
URL_TEMPLATE = u"/api/v1/external/beanstalk?stream={stream}"
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_git_single(self) -> None:
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = "work-test / master"
webhooks: Don't display "Commits by" when committer is the only author. For our Git integrations, we now only display the number of commits pushed when the pusher also happens to be the only author of the commits being pushed. Part of #3968. Follow-up to #4006.
2017-04-26 02:57:47 +02:00
expected_message = """Leo Franchi [pushed](http://lfranchi-svn.beanstalkapp.com/work-test) 1 commit to branch master.
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/beanstalk: Filter specific Git branches.
2017-04-22 02:34:53 +02:00
* add some stuff ([e50508d](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/e50508df))"""
test performance: Pass in users to api_* helpers. This reduces query counts in some cases, since we no longer need to look up the user again. In particular, it reduces some noise when we count queries for O(N)-related tests. The query count is usually reduced by 2 per API call. We no longer need to look up Realm and UserProfile. In most cases we are saving these lookups for the whole tests, since we usually already have the `user` objects for other reasons. In a few places we are simply moving where that query happens within the test. In some places I shorten names like `test_user` or `user_profile` to just be `user`.
2020-03-10 11:48:26 +01:00
self.api_stream_message(self.test_user, 'git_singlecommit', expected_topic, expected_message,
tests: Replace api_auth usages with auth methods in zerver/webhooks.
2017-12-14 19:02:45 +01:00
content_type=None)
webhooks/beanstalk: Filter specific Git branches.
2017-04-22 02:34:53 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_git_single_filtered_by_branches(self) -> None:
webhooks/beanstalk: Filter specific Git branches.
2017-04-22 02:34:53 +02:00
self.url = self.build_webhook_url(branches='master,development')
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = "work-test / master"
webhooks: Don't display "Commits by" when committer is the only author. For our Git integrations, we now only display the number of commits pushed when the pusher also happens to be the only author of the commits being pushed. Part of #3968. Follow-up to #4006.
2017-04-26 02:57:47 +02:00
expected_message = """Leo Franchi [pushed](http://lfranchi-svn.beanstalkapp.com/work-test) 1 commit to branch master.
webhooks/beanstalk: Filter specific Git branches.
2017-04-22 02:34:53 +02:00
git integration: Change push commits message to show url at the end.
2017-03-15 10:15:03 +01:00
* add some stuff ([e50508d](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/e50508df))"""
test performance: Pass in users to api_* helpers. This reduces query counts in some cases, since we no longer need to look up the user again. In particular, it reduces some noise when we count queries for O(N)-related tests. The query count is usually reduced by 2 per API call. We no longer need to look up Realm and UserProfile. In most cases we are saving these lookups for the whole tests, since we usually already have the `user` objects for other reasons. In a few places we are simply moving where that query happens within the test. In some places I shorten names like `test_user` or `user_profile` to just be `user`.
2020-03-10 11:48:26 +01:00
self.api_stream_message(self.test_user, 'git_singlecommit', expected_topic, expected_message,
tests: Replace api_auth usages with auth methods in zerver/webhooks.
2017-12-14 19:02:45 +01:00
content_type=None)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_git_multiple_committers(self) -> None:
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = "work-test / master"
webhooks: Add a space between author and number of commits for Git messages. For Git push messages, we now have a single space character between the name of a commit's author and the number of commits by that author, plus a period at the end. Part of #3968. Follow-up to #4006.
2017-04-26 00:19:47 +02:00
expected_message = """Leo Franchi [pushed](http://lfranchi-svn.beanstalkapp.com/work-test) 3 commits to branch master. Commits by Leo Franchi (2) and Tomasz Kolek (1).
git integrations: Expand details in commit push notifications. We now show a few new things: (1) The number of commits pushed. (2) Who authored the commits (just counts, not which specific ones, for brevity). Add tests for case of multiple committers. Part of #3968.
2017-04-05 09:12:19 +02:00
webhooks/beanstalk: Filter specific Git branches.
2017-04-22 02:34:53 +02:00
* Added new file ([edf529c](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/edf529c7))
* Filled in new file with some stuff ([c2a191b](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/c2a191b9))
* More work to fix some bugs ([2009815](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/20098158))"""
test performance: Pass in users to api_* helpers. This reduces query counts in some cases, since we no longer need to look up the user again. In particular, it reduces some noise when we count queries for O(N)-related tests. The query count is usually reduced by 2 per API call. We no longer need to look up Realm and UserProfile. In most cases we are saving these lookups for the whole tests, since we usually already have the `user` objects for other reasons. In a few places we are simply moving where that query happens within the test. In some places I shorten names like `test_user` or `user_profile` to just be `user`.
2020-03-10 11:48:26 +01:00
self.api_stream_message(self.test_user, 'git_multiple_committers', expected_topic, expected_message,
tests: Replace api_auth usages with auth methods in zerver/webhooks.
2017-12-14 19:02:45 +01:00
content_type=None)
webhooks/beanstalk: Filter specific Git branches.
2017-04-22 02:34:53 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_git_multiple_committers_filtered_by_branches(self) -> None:
webhooks/beanstalk: Filter specific Git branches.
2017-04-22 02:34:53 +02:00
self.url = self.build_webhook_url(branches='master,development')
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = "work-test / master"
webhooks: Add a space between author and number of commits for Git messages. For Git push messages, we now have a single space character between the name of a commit's author and the number of commits by that author, plus a period at the end. Part of #3968. Follow-up to #4006.
2017-04-26 00:19:47 +02:00
expected_message = """Leo Franchi [pushed](http://lfranchi-svn.beanstalkapp.com/work-test) 3 commits to branch master. Commits by Leo Franchi (2) and Tomasz Kolek (1).
webhooks/beanstalk: Filter specific Git branches.
2017-04-22 02:34:53 +02:00
git integrations: Expand details in commit push notifications. We now show a few new things: (1) The number of commits pushed. (2) Who authored the commits (just counts, not which specific ones, for brevity). Add tests for case of multiple committers. Part of #3968.
2017-04-05 09:12:19 +02:00
* Added new file ([edf529c](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/edf529c7))
* Filled in new file with some stuff ([c2a191b](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/c2a191b9))
* More work to fix some bugs ([2009815](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/20098158))"""
test performance: Pass in users to api_* helpers. This reduces query counts in some cases, since we no longer need to look up the user again. In particular, it reduces some noise when we count queries for O(N)-related tests. The query count is usually reduced by 2 per API call. We no longer need to look up Realm and UserProfile. In most cases we are saving these lookups for the whole tests, since we usually already have the `user` objects for other reasons. In a few places we are simply moving where that query happens within the test. In some places I shorten names like `test_user` or `user_profile` to just be `user`.
2020-03-10 11:48:26 +01:00
self.api_stream_message(self.test_user, 'git_multiple_committers', expected_topic, expected_message,
tests: Replace api_auth usages with auth methods in zerver/webhooks.
2017-12-14 19:02:45 +01:00
content_type=None)
git integrations: Expand details in commit push notifications. We now show a few new things: (1) The number of commits pushed. (2) Who authored the commits (just counts, not which specific ones, for brevity). Add tests for case of multiple committers. Part of #3968.
2017-04-05 09:12:19 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_git_multiple(self) -> None:
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = "work-test / master"
webhooks: Don't display "Commits by" when committer is the only author. For our Git integrations, we now only display the number of commits pushed when the pusher also happens to be the only author of the commits being pushed. Part of #3968. Follow-up to #4006.
2017-04-26 02:57:47 +02:00
expected_message = """Leo Franchi [pushed](http://lfranchi-svn.beanstalkapp.com/work-test) 3 commits to branch master.
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/beanstalk: Filter specific Git branches.
2017-04-22 02:34:53 +02:00
* Added new file ([edf529c](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/edf529c7))
* Filled in new file with some stuff ([c2a191b](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/c2a191b9))
* More work to fix some bugs ([2009815](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/20098158))"""
test performance: Pass in users to api_* helpers. This reduces query counts in some cases, since we no longer need to look up the user again. In particular, it reduces some noise when we count queries for O(N)-related tests. The query count is usually reduced by 2 per API call. We no longer need to look up Realm and UserProfile. In most cases we are saving these lookups for the whole tests, since we usually already have the `user` objects for other reasons. In a few places we are simply moving where that query happens within the test. In some places I shorten names like `test_user` or `user_profile` to just be `user`.
2020-03-10 11:48:26 +01:00
self.api_stream_message(self.test_user, 'git_multiple', expected_topic, expected_message,
tests: Replace api_auth usages with auth methods in zerver/webhooks.
2017-12-14 19:02:45 +01:00
content_type=None)
webhooks/beanstalk: Filter specific Git branches.
2017-04-22 02:34:53 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_git_multiple_filtered_by_branches(self) -> None:
webhooks/beanstalk: Filter specific Git branches.
2017-04-22 02:34:53 +02:00
self.url = self.build_webhook_url(branches='master,development')
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = "work-test / master"
webhooks: Don't display "Commits by" when committer is the only author. For our Git integrations, we now only display the number of commits pushed when the pusher also happens to be the only author of the commits being pushed. Part of #3968. Follow-up to #4006.
2017-04-26 02:57:47 +02:00
expected_message = """Leo Franchi [pushed](http://lfranchi-svn.beanstalkapp.com/work-test) 3 commits to branch master.
webhooks/beanstalk: Filter specific Git branches.
2017-04-22 02:34:53 +02:00
git integration: Change push commits message to show url at the end.
2017-03-15 10:15:03 +01:00
* Added new file ([edf529c](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/edf529c7))
* Filled in new file with some stuff ([c2a191b](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/c2a191b9))
* More work to fix some bugs ([2009815](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/20098158))"""
test performance: Pass in users to api_* helpers. This reduces query counts in some cases, since we no longer need to look up the user again. In particular, it reduces some noise when we count queries for O(N)-related tests. The query count is usually reduced by 2 per API call. We no longer need to look up Realm and UserProfile. In most cases we are saving these lookups for the whole tests, since we usually already have the `user` objects for other reasons. In a few places we are simply moving where that query happens within the test. In some places I shorten names like `test_user` or `user_profile` to just be `user`.
2020-03-10 11:48:26 +01:00
self.api_stream_message(self.test_user, 'git_multiple', expected_topic, expected_message,
tests: Replace api_auth usages with auth methods in zerver/webhooks.
2017-12-14 19:02:45 +01:00
content_type=None)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_git_more_than_limit(self) -> None:
git integration: Change push commits message to show url at the end.
2017-03-15 10:15:03 +01:00
commits_info = "* add some stuff ([e50508d](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/e50508df))\n"
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = "work-test / master"
webhooks: Don't display "Commits by" when committer is the only author. For our Git integrations, we now only display the number of commits pushed when the pusher also happens to be the only author of the commits being pushed. Part of #3968. Follow-up to #4006.
2017-04-26 02:57:47 +02:00
expected_message = """Leo Franchi [pushed](http://lfranchi-svn.beanstalkapp.com/work-test) 50 commits to branch master.
Add beanstalk tests for commits more than limit.
2016-10-07 15:30:28 +02:00
Rename consts in lib/webhooks/git.py to make it more general. Rename: PUSH_COMMITS_LIMIT to COMMITS_LIMIT PUSH_COMMIT_ROW_TEMPLATE to COMMIT_ROW_TEMPLATE PUSH_COMMITS_MORE_THAN_LIMIT_TEMPLATE to COMMITS_MORE_THAN_LIMIT_TEMPLATE
2016-10-12 23:27:24 +02:00
{}[and {} more commit(s)]""".format((commits_info * COMMITS_LIMIT), 50 - COMMITS_LIMIT)
test performance: Pass in users to api_* helpers. This reduces query counts in some cases, since we no longer need to look up the user again. In particular, it reduces some noise when we count queries for O(N)-related tests. The query count is usually reduced by 2 per API call. We no longer need to look up Realm and UserProfile. In most cases we are saving these lookups for the whole tests, since we usually already have the `user` objects for other reasons. In a few places we are simply moving where that query happens within the test. In some places I shorten names like `test_user` or `user_profile` to just be `user`.
2020-03-10 11:48:26 +01:00
self.api_stream_message(self.test_user, 'git_morethanlimitcommits', expected_topic, expected_message,
tests: Replace api_auth usages with auth methods in zerver/webhooks.
2017-12-14 19:02:45 +01:00
content_type=None)
Add beanstalk tests for commits more than limit.
2016-10-07 15:30:28 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_git_more_than_limit_filtered_by_branches(self) -> None:
webhooks/beanstalk: Filter specific Git branches.
2017-04-22 02:34:53 +02:00
self.url = self.build_webhook_url(branches='master,development')
commits_info = "* add some stuff ([e50508d](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/e50508df))\n"
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = "work-test / master"
webhooks: Don't display "Commits by" when committer is the only author. For our Git integrations, we now only display the number of commits pushed when the pusher also happens to be the only author of the commits being pushed. Part of #3968. Follow-up to #4006.
2017-04-26 02:57:47 +02:00
expected_message = """Leo Franchi [pushed](http://lfranchi-svn.beanstalkapp.com/work-test) 50 commits to branch master.
webhooks/beanstalk: Filter specific Git branches.
2017-04-22 02:34:53 +02:00
{}[and {} more commit(s)]""".format((commits_info * COMMITS_LIMIT), 50 - COMMITS_LIMIT)
test performance: Pass in users to api_* helpers. This reduces query counts in some cases, since we no longer need to look up the user again. In particular, it reduces some noise when we count queries for O(N)-related tests. The query count is usually reduced by 2 per API call. We no longer need to look up Realm and UserProfile. In most cases we are saving these lookups for the whole tests, since we usually already have the `user` objects for other reasons. In a few places we are simply moving where that query happens within the test. In some places I shorten names like `test_user` or `user_profile` to just be `user`.
2020-03-10 11:48:26 +01:00
self.api_stream_message(self.test_user, 'git_morethanlimitcommits', expected_topic, expected_message,
tests: Replace api_auth usages with auth methods in zerver/webhooks.
2017-12-14 19:02:45 +01:00
content_type=None)
webhooks/beanstalk: Filter specific Git branches.
2017-04-22 02:34:53 +02:00
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
@patch('zerver.webhooks.beanstalk.view.check_send_webhook_message')
def test_git_single_filtered_by_branches_ignore(self, check_send_webhook_message_mock: MagicMock) -> None:
webhooks/beanstalk: Filter specific Git branches.
2017-04-22 02:34:53 +02:00
self.url = self.build_webhook_url(branches='changes,development')
payload = self.get_body('git_singlecommit')
test performance: Pass in users to api_* helpers. This reduces query counts in some cases, since we no longer need to look up the user again. In particular, it reduces some noise when we count queries for O(N)-related tests. The query count is usually reduced by 2 per API call. We no longer need to look up Realm and UserProfile. In most cases we are saving these lookups for the whole tests, since we usually already have the `user` objects for other reasons. In a few places we are simply moving where that query happens within the test. In some places I shorten names like `test_user` or `user_profile` to just be `user`.
2020-03-10 11:48:26 +01:00
result = self.api_post(self.test_user, self.url, payload)
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
self.assertFalse(check_send_webhook_message_mock.called)
webhooks/beanstalk: Filter specific Git branches.
2017-04-22 02:34:53 +02:00
self.assert_json_success(result)
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
@patch('zerver.webhooks.beanstalk.view.check_send_webhook_message')
webhooks/beanstalk: Filter specific Git branches.
2017-04-22 02:34:53 +02:00
def test_git_multiple_committers_filtered_by_branches_ignore(
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
self, check_send_webhook_message_mock: MagicMock) -> None:
webhooks/beanstalk: Filter specific Git branches.
2017-04-22 02:34:53 +02:00
self.url = self.build_webhook_url(branches='changes,development')
payload = self.get_body('git_multiple_committers')
test performance: Pass in users to api_* helpers. This reduces query counts in some cases, since we no longer need to look up the user again. In particular, it reduces some noise when we count queries for O(N)-related tests. The query count is usually reduced by 2 per API call. We no longer need to look up Realm and UserProfile. In most cases we are saving these lookups for the whole tests, since we usually already have the `user` objects for other reasons. In a few places we are simply moving where that query happens within the test. In some places I shorten names like `test_user` or `user_profile` to just be `user`.
2020-03-10 11:48:26 +01:00
result = self.api_post(self.test_user, self.url, payload)
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
self.assertFalse(check_send_webhook_message_mock.called)
webhooks/beanstalk: Filter specific Git branches.
2017-04-22 02:34:53 +02:00
self.assert_json_success(result)
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
@patch('zerver.webhooks.beanstalk.view.check_send_webhook_message')
webhooks/beanstalk: Filter specific Git branches.
2017-04-22 02:34:53 +02:00
def test_git_multiple_filtered_by_branches_ignore(
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
self, check_send_webhook_message_mock: MagicMock) -> None:
webhooks/beanstalk: Filter specific Git branches.
2017-04-22 02:34:53 +02:00
self.url = self.build_webhook_url(branches='changes,development')
payload = self.get_body('git_multiple')
test performance: Pass in users to api_* helpers. This reduces query counts in some cases, since we no longer need to look up the user again. In particular, it reduces some noise when we count queries for O(N)-related tests. The query count is usually reduced by 2 per API call. We no longer need to look up Realm and UserProfile. In most cases we are saving these lookups for the whole tests, since we usually already have the `user` objects for other reasons. In a few places we are simply moving where that query happens within the test. In some places I shorten names like `test_user` or `user_profile` to just be `user`.
2020-03-10 11:48:26 +01:00
result = self.api_post(self.test_user, self.url, payload)
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
self.assertFalse(check_send_webhook_message_mock.called)
webhooks/beanstalk: Filter specific Git branches.
2017-04-22 02:34:53 +02:00
self.assert_json_success(result)
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
@patch('zerver.webhooks.beanstalk.view.check_send_webhook_message')
webhooks/beanstalk: Filter specific Git branches.
2017-04-22 02:34:53 +02:00
def test_git_more_than_limit_filtered_by_branches_ignore(
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
self, check_send_webhook_message_mock: MagicMock) -> None:
webhooks/beanstalk: Filter specific Git branches.
2017-04-22 02:34:53 +02:00
self.url = self.build_webhook_url(branches='changes,development')
payload = self.get_body('git_morethanlimitcommits')
test performance: Pass in users to api_* helpers. This reduces query counts in some cases, since we no longer need to look up the user again. In particular, it reduces some noise when we count queries for O(N)-related tests. The query count is usually reduced by 2 per API call. We no longer need to look up Realm and UserProfile. In most cases we are saving these lookups for the whole tests, since we usually already have the `user` objects for other reasons. In a few places we are simply moving where that query happens within the test. In some places I shorten names like `test_user` or `user_profile` to just be `user`.
2020-03-10 11:48:26 +01:00
result = self.api_post(self.test_user, self.url, payload)
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
self.assertFalse(check_send_webhook_message_mock.called)
webhooks/beanstalk: Filter specific Git branches.
2017-04-22 02:34:53 +02:00
self.assert_json_success(result)
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_svn_addremove(self) -> None:
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = "svn r3"
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
expected_message = """Leo Franchi pushed [revision 3](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/3):
> Removed a file and added another one!"""
test performance: Pass in users to api_* helpers. This reduces query counts in some cases, since we no longer need to look up the user again. In particular, it reduces some noise when we count queries for O(N)-related tests. The query count is usually reduced by 2 per API call. We no longer need to look up Realm and UserProfile. In most cases we are saving these lookups for the whole tests, since we usually already have the `user` objects for other reasons. In a few places we are simply moving where that query happens within the test. In some places I shorten names like `test_user` or `user_profile` to just be `user`.
2020-03-10 11:48:26 +01:00
self.api_stream_message(self.test_user, 'svn_addremove', expected_topic, expected_message,
tests: Replace api_auth usages with auth methods in zerver/webhooks.
2017-12-14 19:02:45 +01:00
content_type=None)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_svn_changefile(self) -> None:
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = "svn r2"
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
expected_message = """Leo Franchi pushed [revision 2](http://lfranchi-svn.beanstalkapp.com/work-test/changesets/2):
> Added some code"""
test performance: Pass in users to api_* helpers. This reduces query counts in some cases, since we no longer need to look up the user again. In particular, it reduces some noise when we count queries for O(N)-related tests. The query count is usually reduced by 2 per API call. We no longer need to look up Realm and UserProfile. In most cases we are saving these lookups for the whole tests, since we usually already have the `user` objects for other reasons. In a few places we are simply moving where that query happens within the test. In some places I shorten names like `test_user` or `user_profile` to just be `user`.
2020-03-10 11:48:26 +01:00
self.api_stream_message(self.test_user, 'svn_changefile', expected_topic, expected_message,
tests: Replace api_auth usages with auth methods in zerver/webhooks.
2017-12-14 19:02:45 +01:00
content_type=None)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Change use of typing.Text to str.
2018-05-10 19:34:01 +02:00
def get_body(self, fixture_name: str) -> Dict[str, str]:
tests: Refactor use of test and webhook data fixtures.
2018-04-20 03:57:21 +02:00
return {'payload': self.webhook_fixture_data('beanstalk', fixture_name)}